Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 260083011: Return MaybeHandle from Object::ToSmi. (Closed)

Created:
6 years, 7 months ago by Yang
Modified:
6 years, 7 months ago
Reviewers:
ulan
CC:
v8-dev
Visibility:
Public.

Description

Return MaybeHandle from Object::ToSmi. R=ulan@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21047

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -12 lines) Patch
M src/elements.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M src/ic.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M src/objects.h View 1 chunk +2 lines, -3 lines 0 comments Download
M src/objects-inl.h View 2 chunks +3 lines, -3 lines 0 comments Download
M test/cctest/test-strings.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Yang
6 years, 7 months ago (2014-04-29 10:47:20 UTC) #1
ulan
lgtm
6 years, 7 months ago (2014-04-29 10:51:27 UTC) #2
Yang
6 years, 7 months ago (2014-04-29 13:18:37 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r21047 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698