test/cctest/test-strings.cc - Issue 260083011: Return MaybeHandle from Object::ToSmi.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/cctest/test-strings.cc

Issue 260083011: Return MaybeHandle from Object::ToSmi. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: test/cctest/test-strings.cc

diff --git a/test/cctest/test-strings.cc b/test/cctest/test-strings.cc

index cf7bb6fd941e34bdc9788a3d0b6b6c532d946662..cfeeee8ac7b1e9508eabfb8490413b2c35f8b5ce 100644

--- a/test/cctest/test-strings.cc

+++ b/test/cctest/test-strings.cc

@@ -1087,7 +1087,7 @@ TEST(CachedHashOverflow) {

CHECK_EQ(results[i]->IsUndefined(), result->IsUndefined());

CHECK_EQ(results[i]->IsNumber(), result->IsNumber());

if (result->IsNumber()) {

- CHECK_EQ(Handle<Smi>::cast(Object::ToSmi(isolate, results[i]))->value(),

+ CHECK_EQ(Object::ToSmi(isolate, results[i]).ToHandleChecked()->value(),

result->ToInt32()->Value());

}

« no previous file with comments | « src/objects-inl.h ('k') | no next file » | no next file with comments »