Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(500)

Issue 2600763002: [stubs] Remove dead string copying code (Closed)

Created:
3 years, 12 months ago by danno
Modified:
3 years, 12 months ago
Reviewers:
Igor Sheludko
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[stubs] Remove dead string copying code Review-Url: https://codereview.chromium.org/2600763002 Cr-Commit-Position: refs/heads/master@{#41956} Committed: https://chromium.googlesource.com/v8/v8/+/47e1cc4685af88815b3fa6bf7648544bab7d8d18

Patch Set 1 #

Patch Set 2 : [stubs] Remove dead string copying code #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -386 lines) Patch
M src/arm/code-stubs-arm.h View 1 chunk +0 lines, -11 lines 0 comments Download
M src/arm/code-stubs-arm.cc View 1 chunk +0 lines, -40 lines 0 comments Download
M src/ia32/code-stubs-ia32.h View 1 chunk +0 lines, -10 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 chunk +0 lines, -34 lines 0 comments Download
M src/mips/code-stubs-mips.h View 1 chunk +0 lines, -11 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 1 chunk +0 lines, -45 lines 0 comments Download
M src/mips64/code-stubs-mips64.h View 1 chunk +0 lines, -11 lines 0 comments Download
M src/mips64/code-stubs-mips64.cc View 1 chunk +0 lines, -45 lines 0 comments Download
M src/ppc/code-stubs-ppc.h View 1 chunk +0 lines, -9 lines 0 comments Download
M src/ppc/code-stubs-ppc.cc View 1 chunk +0 lines, -39 lines 0 comments Download
M src/s390/code-stubs-s390.h View 1 chunk +0 lines, -9 lines 0 comments Download
M src/s390/code-stubs-s390.cc View 1 chunk +0 lines, -38 lines 0 comments Download
M src/x64/code-stubs-x64.h View 1 chunk +0 lines, -9 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 1 chunk +0 lines, -31 lines 0 comments Download
M src/x87/code-stubs-x87.h View 1 chunk +0 lines, -10 lines 0 comments Download
M src/x87/code-stubs-x87.cc View 1 chunk +0 lines, -34 lines 0 comments Download

Messages

Total messages: 16 (12 generated)
danno
PTAL
3 years, 12 months ago (2016-12-27 09:09:58 UTC) #8
Igor Sheludko
lgtm
3 years, 12 months ago (2016-12-27 09:10:56 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2600763002/20001
3 years, 12 months ago (2016-12-27 10:12:33 UTC) #13
commit-bot: I haz the power
3 years, 12 months ago (2016-12-27 10:14:23 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/47e1cc4685af88815b3fa6bf7648544bab7...

Powered by Google App Engine
This is Rietveld 408576698