[Password Manager] Fix icons on chrome://settings/passwords

[Password Manager] Fix icons on chrome://settings/passwords

Before this CL requests to the favicon service looked like the following:
chrome://favicon/size/16@1x/origin/https://twitter.com/signup

The "origin" parameter means that
a) the path should be removed
b) the "http" scheme should be added, if it is missed
(see details here
https://cs.chromium.org/chromium/src/chrome/browser/ui/webui/favicon_source.h).

The favicon service fetches icons from the history backend. If the path has
been removed from the URL, new URL might be absent in the history or even not
exist on the given site. Therefore, we might fail to fetch icon.
So, the removing the path doesn't make sense and the "origin/" parameter should
be removed. The bookmarks manager also doesn't use this parameter.

The parameter was added in vabr@'s CL
(https://codereview.chromium.org/10079024) which has a comment about "origin/".
The comment doesn't match to how the favicon service works.

BUG=672483
TBR=dbeam@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2568063002
Cr-Commit-Position: refs/heads/master@{#438465}
(cherry picked from commit 6178699a5a0ba0c505e336e7caf449a32467cba0)

Review-Url: https://codereview.chromium.org/2600723002

[kolos1, 2016-12-23 12:46:48]

Description was changed from

==========
[Password Manager] Fix icons on chrome://settings/passwords

Before this CL requests to the favicon service looked like the following:
chrome://favicon/size/16@1x/origin/https://twitter.com/signup

The "origin" parameter means that
a) the path should be removed
b) the "http" scheme should be added, if it is missed
(see details here
https://cs.chromium.org/chromium/src/chrome/browser/ui/webui/favicon_source.h).

The favicon service fetches icons from the history backend. If the path has
been removed from the URL, new URL might be absent in the history or even not
exist on the given site. Therefore, we might fail to fetch icon.
So, the removing the path doesn't make sense and the "origin/" parameter should
be removed. The bookmarks manager also doesn't use this parameter.

The parameter was added in vabr@'s CL
(https://codereview.chromium.org/10079024) which has a comment about "origin/".
The comment doesn't match to how the favicon service works.

BUG=672483
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2568063002
Cr-Commit-Position: refs/heads/master@{#438465}
(cherry picked from commit 6178699a5a0ba0c505e336e7caf449a32467cba0)
==========

to

==========
[Password Manager] Fix icons on chrome://settings/passwords

Before this CL requests to the favicon service looked like the following:
chrome://favicon/size/16@1x/origin/https://twitter.com/signup

The "origin" parameter means that
a) the path should be removed
b) the "http" scheme should be added, if it is missed
(see details here
https://cs.chromium.org/chromium/src/chrome/browser/ui/webui/favicon_source.h).

The favicon service fetches icons from the history backend. If the path has
been removed from the URL, new URL might be absent in the history or even not
exist on the given site. Therefore, we might fail to fetch icon.
So, the removing the path doesn't make sense and the "origin/" parameter should
be removed. The bookmarks manager also doesn't use this parameter.

The parameter was added in vabr@'s CL
(https://codereview.chromium.org/10079024) which has a comment about "origin/".
The comment doesn't match to how the favicon service works.

BUG=672483
TBR=dbeam@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2568063002
Cr-Commit-Position: refs/heads/master@{#438465}
(cherry picked from commit 6178699a5a0ba0c505e336e7caf449a32467cba0)
==========

[kolos1, 2016-12-23 12:49:46]

The CQ bit was checked by kolos@chromium.org

[commit-bot: I haz the power, 2016-12-23 12:49:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-23 12:49:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-23 12:49:58]

CLs for remote refs other than refs/pending/heads/master must contain NOTRY=true
and NOPRESUBMIT=true in order for the CQ to process them

[kolos1, 2016-12-23 12:54:32]

Description was changed from

==========
[Password Manager] Fix icons on chrome://settings/passwords

Before this CL requests to the favicon service looked like the following:
chrome://favicon/size/16@1x/origin/https://twitter.com/signup

The "origin" parameter means that
a) the path should be removed
b) the "http" scheme should be added, if it is missed
(see details here
https://cs.chromium.org/chromium/src/chrome/browser/ui/webui/favicon_source.h).

The favicon service fetches icons from the history backend. If the path has
been removed from the URL, new URL might be absent in the history or even not
exist on the given site. Therefore, we might fail to fetch icon.
So, the removing the path doesn't make sense and the "origin/" parameter should
be removed. The bookmarks manager also doesn't use this parameter.

The parameter was added in vabr@'s CL
(https://codereview.chromium.org/10079024) which has a comment about "origin/".
The comment doesn't match to how the favicon service works.

BUG=672483
TBR=dbeam@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2568063002
Cr-Commit-Position: refs/heads/master@{#438465}
(cherry picked from commit 6178699a5a0ba0c505e336e7caf449a32467cba0)
==========

to

==========
[Password Manager] Fix icons on chrome://settings/passwords

Before this CL requests to the favicon service looked like the following:
chrome://favicon/size/16@1x/origin/https://twitter.com/signup

The "origin" parameter means that
a) the path should be removed
b) the "http" scheme should be added, if it is missed
(see details here
https://cs.chromium.org/chromium/src/chrome/browser/ui/webui/favicon_source.h).

The favicon service fetches icons from the history backend. If the path has
been removed from the URL, new URL might be absent in the history or even not
exist on the given site. Therefore, we might fail to fetch icon.
So, the removing the path doesn't make sense and the "origin/" parameter should
be removed. The bookmarks manager also doesn't use this parameter.

The parameter was added in vabr@'s CL
(https://codereview.chromium.org/10079024) which has a comment about "origin/".
The comment doesn't match to how the favicon service works.

BUG=672483
TBR=dbeam@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2568063002
Cr-Commit-Position: refs/heads/master@{#438465}
(cherry picked from commit 6178699a5a0ba0c505e336e7caf449a32467cba0)
==========

[kolos1, 2016-12-23 12:55:40]

The CQ bit was checked by kolos@chromium.org

[commit-bot: I haz the power, 2016-12-23 12:55:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-23 12:58:45]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1482497740179200, "parent_rev":
"f9a9f4ed858f97d06410621e4760c076a1df3b30", "commit_rev":
"c462704d42e07dc112cccb3b0f31f9eac5e2a710"}

[commit-bot: I haz the power, 2016-12-23 12:59:15]

Description was changed from

==========
[Password Manager] Fix icons on chrome://settings/passwords

Before this CL requests to the favicon service looked like the following:
chrome://favicon/size/16@1x/origin/https://twitter.com/signup

The "origin" parameter means that
a) the path should be removed
b) the "http" scheme should be added, if it is missed
(see details here
https://cs.chromium.org/chromium/src/chrome/browser/ui/webui/favicon_source.h).

The favicon service fetches icons from the history backend. If the path has
been removed from the URL, new URL might be absent in the history or even not
exist on the given site. Therefore, we might fail to fetch icon.
So, the removing the path doesn't make sense and the "origin/" parameter should
be removed. The bookmarks manager also doesn't use this parameter.

The parameter was added in vabr@'s CL
(https://codereview.chromium.org/10079024) which has a comment about "origin/".
The comment doesn't match to how the favicon service works.

BUG=672483
TBR=dbeam@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2568063002
Cr-Commit-Position: refs/heads/master@{#438465}
(cherry picked from commit 6178699a5a0ba0c505e336e7caf449a32467cba0)
==========

to

==========
[Password Manager] Fix icons on chrome://settings/passwords

Before this CL requests to the favicon service looked like the following:
chrome://favicon/size/16@1x/origin/https://twitter.com/signup

The "origin" parameter means that
a) the path should be removed
b) the "http" scheme should be added, if it is missed
(see details here
https://cs.chromium.org/chromium/src/chrome/browser/ui/webui/favicon_source.h).

The favicon service fetches icons from the history backend. If the path has
been removed from the URL, new URL might be absent in the history or even not
exist on the given site. Therefore, we might fail to fetch icon.
So, the removing the path doesn't make sense and the "origin/" parameter should
be removed. The bookmarks manager also doesn't use this parameter.

The parameter was added in vabr@'s CL
(https://codereview.chromium.org/10079024) which has a comment about "origin/".
The comment doesn't match to how the favicon service works.

BUG=672483
TBR=dbeam@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2568063002
Cr-Commit-Position: refs/heads/master@{#438465}
(cherry picked from commit 6178699a5a0ba0c505e336e7caf449a32467cba0)

Review-Url: https://codereview.chromium.org/2600723002
==========

[commit-bot: I haz the power, 2016-12-23 12:59:16]

Committed patchset #1 (id:1)