PlzNavigate: cancel any scheduled navigations when deciding to let the embedder handle a navigation.

PlzNavigate: cancel any scheduled navigations when deciding to let the embedder handle a navigation.

This fixes the following layout tests in PlzNavigate mode:
imported/wpt/html/browsers/browsing-the-web/navigating-across-documents/005.html
imported/wpt/html/browsers/browsing-the-web/navigating-across-documents/006.html
imported/wpt/html/browsers/browsing-the-web/navigating-across-documents/007.html

BUG=673751
Committed: https://crrev.com/d026a0c087e5bd358b9827dd77395fca829e44c7
Cr-Commit-Position: refs/heads/master@{#440923}

[yzshen1, 2016-12-23 00:20:52]

The CQ bit was checked by yzshen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-23 00:21:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yzshen1, 2016-12-23 00:21:16]

yzshen@chromium.org changed reviewers:
+ jam@chromium.org

[yzshen1, 2016-12-23 00:21:17]

Hi, John.

Would you please take a look? Thanks!

[commit-bot: I haz the power, 2016-12-23 02:57:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-23 02:57:36]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[jam, 2016-12-27 18:17:52]

Description was changed from

==========
PlzNavigate: cancel any scheduled navigations when deciding to let the embedder
handle a navigation.

BUG=673751
==========

to

==========
PlzNavigate: cancel any scheduled navigations when deciding to let the embedder
handle a navigation.

BUG=673751
==========

[jam, 2016-12-27 18:17:52]

jam@chromium.org changed reviewers:
+ japhet@chromium.org

[jam, 2016-12-27 18:21:11]

On 2016/12/23 00:21:17, yzshen1 wrote:
> Hi, John.
> 
> Would you please take a look? Thanks!

this lgtm but I'm not an owner there, +Nate who's been doing PlzNavigate reviews
in this area

Can you also list which tests this fixed in the cl description? You can also
update webkit filter in this cl (note since it's not in testing/buildbot, the
issue we have with CQ not retrying without the patch doesn't exist). The file is
third_party\WebKit\LayoutTests\FlagExpectations\enable-browser-side-navigation

[Nate Chapin, 2016-12-27 23:26:49]

LGTM2, but I'd also like to know exactly which tests this fixes :)

[yzshen1, 2016-12-29 00:11:15]

Description was changed from

==========
PlzNavigate: cancel any scheduled navigations when deciding to let the embedder
handle a navigation.

BUG=673751
==========

to

==========
PlzNavigate: cancel any scheduled navigations when deciding to let the embedder
handle a navigation.

This fixes the following layout tests in PlzNavigate mode:
imported/wpt/html/browsers/browsing-the-web/navigating-across-documents/005.html
imported/wpt/html/browsers/browsing-the-web/navigating-across-documents/006.html
imported/wpt/html/browsers/browsing-the-web/navigating-across-documents/007.html

BUG=673751
==========

[yzshen1, 2016-12-29 00:15:20]

The CQ bit was checked by yzshen@chromium.org

[yzshen1, 2016-12-29 00:15:20]

The patchset sent to the CQ was uploaded after l-g-t-m from jam@chromium.org
Link to the patchset: https://codereview.chromium.org/2600653002/#ps20001
(title: ".")

[commit-bot: I haz the power, 2016-12-29 00:15:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yzshen1, 2016-12-29 00:16:23]

On 2016/12/27 23:26:49, Nate Chapin (slow until Jan 3) wrote:
> LGTM2, but I'd also like to know exactly which tests this fixes :)

Thanks John and Nate!

I have updated the CL description with the tests that this fixes; and also
updated the filter in this CL.

[commit-bot: I haz the power, 2016-12-29 01:53:03]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1482970520110500,
"parent_rev": "e9d507557a826b9c192700d3dca17943c71e2d63", "commit_rev":
"6d24c4f65dfb592f5fa09e486924d50b70b25d43"}

[commit-bot: I haz the power, 2016-12-29 01:53:31]

Description was changed from

==========
PlzNavigate: cancel any scheduled navigations when deciding to let the embedder
handle a navigation.

This fixes the following layout tests in PlzNavigate mode:
imported/wpt/html/browsers/browsing-the-web/navigating-across-documents/005.html
imported/wpt/html/browsers/browsing-the-web/navigating-across-documents/006.html
imported/wpt/html/browsers/browsing-the-web/navigating-across-documents/007.html

BUG=673751
==========

to

==========
PlzNavigate: cancel any scheduled navigations when deciding to let the embedder
handle a navigation.

This fixes the following layout tests in PlzNavigate mode:
imported/wpt/html/browsers/browsing-the-web/navigating-across-documents/005.html
imported/wpt/html/browsers/browsing-the-web/navigating-across-documents/006.html
imported/wpt/html/browsers/browsing-the-web/navigating-across-documents/007.html

BUG=673751

Review-Url: https://codereview.chromium.org/2600653002
==========

[commit-bot: I haz the power, 2016-12-29 01:53:32]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2017-01-02 15:51:22]

Description was changed from

==========
PlzNavigate: cancel any scheduled navigations when deciding to let the embedder
handle a navigation.

This fixes the following layout tests in PlzNavigate mode:
imported/wpt/html/browsers/browsing-the-web/navigating-across-documents/005.html
imported/wpt/html/browsers/browsing-the-web/navigating-across-documents/006.html
imported/wpt/html/browsers/browsing-the-web/navigating-across-documents/007.html

BUG=673751

Review-Url: https://codereview.chromium.org/2600653002
==========

to

==========
PlzNavigate: cancel any scheduled navigations when deciding to let the embedder
handle a navigation.

This fixes the following layout tests in PlzNavigate mode:
imported/wpt/html/browsers/browsing-the-web/navigating-across-documents/005.html
imported/wpt/html/browsers/browsing-the-web/navigating-across-documents/006.html
imported/wpt/html/browsers/browsing-the-web/navigating-across-documents/007.html

BUG=673751

Committed: https://crrev.com/d026a0c087e5bd358b9827dd77395fca829e44c7
Cr-Commit-Position: refs/heads/master@{#440923}
==========

[commit-bot: I haz the power, 2017-01-02 15:51:23]

Patchset 2 (id:??) landed as
https://crrev.com/d026a0c087e5bd358b9827dd77395fca829e44c7
Cr-Commit-Position: refs/heads/master@{#440923}