Add nacl_loader_unittests to the chromium_builder_tests

Add nacl_loader_unittests to the chromium_builder_tests

Now nacl_loader target is built on all platforms. Also,
nacl_loader target was renamed to nacl_linux.

TEST=ninja -C out/Release chromium_builder_tests
TEST=GYP_DEFINES='disable_nacl=1' ./build/gyp_chromium \
     ninja -C out/Release chromium_builder_tests
TEST=trybots
BUG=364751
R=mseaborn@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266769

[hamaji, 2014-04-28 14:38:46]

Added disable_nacl==0 condition this time...

[Mark Seaborn, 2014-04-28 15:31:49]

https://codereview.chromium.org/260063002/diff/1/build/all.gyp
File build/all.gyp (right):

https://codereview.chromium.org/260063002/diff/1/build/all.gyp#newcode341
build/all.gyp:341: ['OS=="linux"', {
Hmm, nacl_loader_unittests shouldn't really be conditional on Linux.  This will
make the Buildbot config more complex than it needs to be, because it will need
a conditional too.

The "nacl_helper" executable might be Linux-specific, but "nacl/loader" isn't.

Can you make nacl_loader_unittests built on all platforms, but just add
nonsfi_sandbox_unittest.cc to it conditionally?

[hamaji, 2014-04-28 18:03:18]

I think "nacl_loader" target was misnamed. I renamed it to nacl_linux.

Sorry for uploading many patch sets unnecessarily. Gyp is hard :(

I think linux_rel, linux_rel_precise32, mac_rel, win_rel,
and win_x64_rel will build nacl_loader_unittests binary.

https://codereview.chromium.org/260063002/diff/1/build/all.gyp
File build/all.gyp (right):

https://codereview.chromium.org/260063002/diff/1/build/all.gyp#newcode341
build/all.gyp:341: ['OS=="linux"', {
On 2014/04/28 15:31:49, Mark Seaborn wrote:
> Hmm, nacl_loader_unittests shouldn't really be conditional on Linux.  This
will
> make the Buildbot config more complex than it needs to be, because it will
need
> a conditional too.
> 
> The "nacl_helper" executable might be Linux-specific, but "nacl/loader" isn't.
> 
> Can you make nacl_loader_unittests built on all platforms, but just add
> nonsfi_sandbox_unittest.cc to it conditionally?

Done, but I'm not sure this works on Windows and Mac. We may need to
wait the results of trybots.

[Mark Seaborn, 2014-04-28 18:28:17]

LGTM

[hamaji, 2014-04-29 01:52:38]

The CQ bit was checked by hamaji@chromium.org

[commit-bot: I haz the power, 2014-04-29 01:53:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hamaji@chromium.org/260063002/80001

[commit-bot: I haz the power, 2014-04-29 02:38:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-29 02:38:34]

Try jobs failed on following builders:
  tryserver.chromium on chromium_presubmit

[hamaji, 2014-04-29 04:58:30]

The CQ bit was checked by hamaji@chromium.org

[commit-bot: I haz the power, 2014-04-29 04:59:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hamaji@chromium.org/260063002/80001

[commit-bot: I haz the power, 2014-04-29 05:42:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-29 05:42:05]

Try jobs failed on following builders:
  tryserver.chromium on chromium_presubmit

[hamaji, 2014-04-29 06:35:09]

The CQ bit was checked by hamaji@chromium.org

[commit-bot: I haz the power, 2014-04-29 06:35:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hamaji@chromium.org/260063002/80001

[commit-bot: I haz the power, 2014-04-29 07:12:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-29 07:12:48]

Try jobs failed on following builders:
  tryserver.chromium on chromium_presubmit

[hamaji, 2014-04-29 07:33:10]

Committed patchset #6 manually as r266769 (presubmit successful).