Add nacl_loader_unittests to the chromium_builder_tests

build/all.gyp

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 {
   'variables': {
     # A hook that can be overridden in other repositories to add additional
     # compilation targets to 'All'. Only used on Android.
     'android_app_targets%': [],
   },
@@ skipping 320 matching lines @@
                 'VCLinkerTool': {
                   # Enable profile information (necessary for SyzyAsan
                   # instrumentation). This is incompatible with incremental
                   # linking.
                   'Profile': 'true',
                 },
               }
             }],
           ],
         }],
         ['OS=="linux"', {

[Mark Seaborn, 2014/04/28 15:31:49]

Hmm, nacl_loader_unittests shouldn't really be conditional on Linux.  This will
make the Buildbot config more complex than it needs to be, because it will need
a conditional too.

The "nacl_helper" executable might be Linux-specific, but "nacl/loader" isn't.

Can you make nacl_loader_unittests built on all platforms, but just add
nonsfi_sandbox_unittest.cc to it conditionally?

[hamaji, 2014/04/28 18:03:18]

Done, but I'm not sure this works on Windows and Mac. We may need to
wait the results of trybots.

           'dependencies': [
             '../dbus/dbus.gyp:dbus_unittests',
             '../sandbox/sandbox.gyp:sandbox_linux_unittests',
           ],
+          'conditions': [
+            ['disable_nacl==0', {
+              'dependencies': [
+                '../components/nacl.gyp:nacl_loader_unittests',
+              ],
+            }],
+          ]
         }],
         ['OS=="mac"', {
           'dependencies': [
             '../ui/app_list/app_list.gyp:app_list_unittests',
             '../ui/message_center/message_center.gyp:*',
           ],
         }],
         ['test_isolation_mode != "noop"', {
           'dependencies': [
             'chromium_swarm_tests',
@@ skipping 880 matching lines @@
             # http://crbug.com/157234
             #'../chrome/chrome.gyp:sync_integration_tests_run',
             '../chrome/chrome.gyp:unit_tests_run',
             '../net/net.gyp:net_unittests_run',
           ],
         }, # target_name: chromium_swarm_tests
       ],
     }],
   ], # conditions
 }