Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 2600603002: Remove base::ScopedPtrHashMap from media/. (Closed)

Created:
4 years ago by Avi (use Gerrit)
Modified:
3 years, 11 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, feature-media-reviews_chromium.org, piman+watch_chromium.org, eme-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove base::ScopedPtrHashMap from media/. BUG=579229 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/07ef9ade1609f8a40417179a9195adf993fee2ff Cr-Commit-Position: refs/heads/master@{#440820}

Patch Set 1 #

Patch Set 2 : rev #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -22 lines) Patch
M media/base/cdm_promise_adapter.h View 2 chunks +3 lines, -4 lines 0 comments Download
M media/base/cdm_promise_adapter.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M media/blink/webencryptedmediaclient_impl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M media/blink/webencryptedmediaclient_impl.cc View 1 1 chunk +4 lines, -6 lines 0 comments Download
M media/cdm/aes_decryptor.h View 2 chunks +4 lines, -4 lines 0 comments Download
M media/cdm/aes_decryptor.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/gpu/ipc/service/media_gpu_channel_manager.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M media/gpu/ipc/service/media_gpu_channel_manager.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 20 (14 generated)
Avi (use Gerrit)
For any reviewer in the office during the holidays.
4 years ago (2016-12-23 02:05:40 UTC) #11
watk
On 2016/12/23 02:05:40, Avi wrote: > For any reviewer in the office during the holidays. ...
3 years, 12 months ago (2016-12-27 22:44:22 UTC) #12
watk
On 2016/12/27 22:44:22, watk wrote: > On 2016/12/23 02:05:40, Avi wrote: > > For any ...
3 years, 12 months ago (2016-12-27 23:02:33 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2600603002/20001
3 years, 12 months ago (2016-12-27 23:13:43 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
3 years, 12 months ago (2016-12-28 02:05:06 UTC) #18
commit-bot: I haz the power
3 years, 11 months ago (2017-01-02 15:48:14 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/07ef9ade1609f8a40417179a9195adf993fee2ff
Cr-Commit-Position: refs/heads/master@{#440820}

Powered by Google App Engine
This is Rietveld 408576698