Chromium Code Reviews Chromium Code Reviews
Issue 2600593002:
Fix touch event flag may not be updated correctly by transform which causes no layout (Closed)
| Index: third_party/WebKit/LayoutTests/fast/events/touch/compositor-touch-hit-rects-geometry-change-as-touch-notified-by-nolayout.html |
| diff --git a/third_party/WebKit/LayoutTests/fast/events/touch/compositor-touch-hit-rects-geometry-change-as-touch-notified-by-nolayout.html b/third_party/WebKit/LayoutTests/fast/events/touch/compositor-touch-hit-rects-geometry-change-as-touch-notified-by-nolayout.html |
| new file mode 100644 |
| index 0000000000000000000000000000000000000000..8668ac990185b6fc96e65db0e180597553bc06d6 |
| --- /dev/null |
| +++ b/third_party/WebKit/LayoutTests/fast/events/touch/compositor-touch-hit-rects-geometry-change-as-touch-notified-by-nolayout.html |
| @@ -0,0 +1,39 @@ |
| +<!DOCTYPE html> |
| +<style> |
| +#box { |
| + position: absolute; |
| + top: 100px; |
| + left: 100px; |
| + width: 50px; |
| + height: 50px; |
| + background-color: blue; |
| +} |
| +</style> |
| + |
| +<p id="description"> |
| +This test verifies the touch event target rects are updated correctly when |
| +a slider transfroms without creating layout. |
|
majidvp
2017/01/02 21:01:10
s/creating/causing/
majidvp
2017/01/02 21:01:10
what do you mean by a slider? This is true for any
yigu
2017/01/03 21:21:34
Done.
yigu
2017/01/03 21:21:35
Done.
|
| +</p> |
| + |
| +<div id="box"></div> |
| +<div id='console' style='display:none;'></div> |
|
majidvp
2017/01/02 21:01:10
The use of single quote (') and double quote (") i
yigu
2017/01/03 21:21:35
Done.
|
| + |
| +<script src="../../../../resources/testharness.js"></script> |
| +<script src="../../../../resources/testharnessreport.js"></script> |
|
majidvp
2017/01/02 21:01:10
testharness.js and testharnessreport.js seem unuse
yigu
2017/01/03 21:21:35
Done.
|
| +<script src="resources/compositor-touch-hit-rects.js"></script> |
| +<script> |
| +window.onload = () => { |
|
majidvp
2017/01/02 21:01:10
do you actually need to have the test in onload ha
yigu
2017/01/03 21:21:35
Done.
|
| + const box = document.getElementById("box"); |
| + box.addEventListener('touchstart', () => {}, false); |
| + internals.forceCompositingUpdate(document); |
| + logRects(box, true); |
|
majidvp
2017/01/02 21:01:10
'compositor-touch-hit-rects.js' already has facili
yigu
2017/01/03 21:21:35
As we discussed, preRunHandlerForTest may not be s
|
| + |
| + // The slider should be able to translate to a new location |
| + box.style.transform = "translate(50px,0px)"; |
| + internals.forceCompositingUpdate(document); |
| + logRects(box, true); |
| + |
| + document.getElementById('console').style.display = 'block'; |
| +}; |
| + |
| +</script> |
