third_party/WebKit/LayoutTests/fast/events/touch/compositor-touch-hit-rects-geometry-change-as-touch-notified-by-nolayout.html - Issue 2600593002: Fix touch event flag may not be updated correctly by transform which causes no layout

Side by Side Diff: third_party/WebKit/LayoutTests/fast/events/touch/compositor-touch-hit-rects-geometry-change-as-touch-notified-by-nolayout.html

Issue 2600593002: Fix touch event flag may not be updated correctly by transform which causes no layout (Closed)

Patch Set: Use absolute position for cross-platform purpose Created 3 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/fast/events/touch/compositor-touch-hit-rects-geometry-change-as-touch-notified-by-nolayout-expected.txt » ('j') | third_party/WebKit/Source/core/paint/PaintLayer.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <style>

	3 #box {

	4 position: absolute;

	5 top: 100px;

	6 left: 100px;

	7 width: 50px;

	8 height: 50px;

	9 background-color: blue;

	10 }

	11 </style>

	12

	13 <p id="description">

	14 This test verifies the touch event target rects are updated correctly when

	15 a slider transfroms without creating layout.
	majidvp 2017/01/02 21:01:10 s/creating/causing/ s/creating/causing/ majidvp 2017/01/02 21:01:10 what do you mean by a slider? This is true for any what do you mean by a slider? This is true for any element and not just a "slider". yigu 2017/01/03 21:21:34 Done. Show quoted text On 2017/01/02 21:01:10, majidvp wrote: > s/creating/causing/ Done. yigu 2017/01/03 21:21:35 Done. Show quoted text On 2017/01/02 21:01:10, majidvp wrote: > s/creating/causing/ Done.
	16 </p>

	17

	18 <div id="box"></div>

	19 <div id='console' style='display:none;'></div>
	majidvp 2017/01/02 21:01:10 The use of single quote (') and double quote (") i The use of single quote (') and double quote (") is inconsistent here and elsewhere in this test. Please make it consistent. https://www.chromium.org/blink/coding-style/layout-test-style-guidelines#TOC-... yigu 2017/01/03 21:21:35 Done. Show quoted text On 2017/01/02 21:01:10, majidvp wrote: > The use of single quote (') and double quote (") is inconsistent here and > elsewhere in this test. Please make it consistent. > > https://www.chromium.org/blink/coding-style/layout-test-style-guidelines#TOC-... Done.
	20

	21 <script src="../../../../resources/testharness.js"></script>

	22 <script src="../../../../resources/testharnessreport.js"></script>
	majidvp 2017/01/02 21:01:10 testharness.js and testharnessreport.js seem unuse testharness.js and testharnessreport.js seem unused. Please remove. yigu 2017/01/03 21:21:35 Done. Show quoted text On 2017/01/02 21:01:10, majidvp wrote: > testharness.js and testharnessreport.js seem unused. Please remove. Done.
	23 <script src="resources/compositor-touch-hit-rects.js"></script>

	24 <script>

	25 window.onload = () => {
	majidvp 2017/01/02 21:01:10 do you actually need to have the test in onload ha do you actually need to have the test in onload handler? yigu 2017/01/03 21:21:35 Done. Show quoted text On 2017/01/02 21:01:10, majidvp wrote: > do you actually need to have the test in onload handler? Done.
	26 const box = document.getElementById("box");

	27 box.addEventListener('touchstart', () => {}, false);

	28 internals.forceCompositingUpdate(document);

	29 logRects(box, true);
	majidvp 2017/01/02 21:01:10 'compositor-touch-hit-rects.js' already has facili 'compositor-touch-hit-rects.js' already has facilities for what you are doing here i.e., adding touchstart handler, forcing compositing, logging the rect). So I think you could just replace this test with a simple 'preRunHandlerForTest' That updates the transform. See for example: fast/events/touch/compositor-touch-hit-rects-scroll.html yigu 2017/01/03 21:21:35 As we discussed, preRunHandlerForTest may not be s Show quoted text On 2017/01/02 21:01:10, majidvp wrote: > 'compositor-touch-hit-rects.js' already has facilities for what you are doing > here i.e., adding touchstart handler, forcing compositing, logging the rect). So > I think you could just replace this test with a simple 'preRunHandlerForTest' > That updates the transform. > > See for example: > fast/events/touch/compositor-touch-hit-rects-scroll.html As we discussed, preRunHandlerForTest may not be suitable for this test.
	30

	31 // The slider should be able to translate to a new location

	32 box.style.transform = "translate(50px,0px)";

	33 internals.forceCompositingUpdate(document);

	34 logRects(box, true);

	35

	36 document.getElementById('console').style.display = 'block';

	37 };

	38

	39 </script>

OLD	NEW