Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(502)

Issue 2600583002: Remove ScopedVector from components/sessions. (Closed)

Created:
4 years ago by Avi (use Gerrit)
Modified:
3 years, 11 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove ScopedVector from components/sessions. BUG=554289, 561329 Committed: https://crrev.com/51f1cd9460c0e166805ceb6d47a4380408c9fae6 Cr-Commit-Position: refs/heads/master@{#441162}

Patch Set 1 #

Patch Set 2 : ios #

Patch Set 3 : fixes #

Total comments: 2

Patch Set 4 : include #

Unified diffs Side-by-side diffs Delta from patch set Stats (+129 lines, -132 lines) Patch
M chrome/browser/sessions/session_service.h View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/sessions/session_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sessions/session_service_test_helper.cc View 2 chunks +1 line, -2 lines 0 comments Download
M components/sessions/core/base_session_service.h View 4 chunks +3 lines, -4 lines 0 comments Download
M components/sessions/core/base_session_service.cc View 5 chunks +16 lines, -15 lines 0 comments Download
M components/sessions/core/base_session_service_test_helper.h View 1 2 2 chunks +5 lines, -2 lines 0 comments Download
M components/sessions/core/base_session_service_test_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/sessions/core/persistent_tab_restore_service.cc View 4 chunks +7 lines, -7 lines 0 comments Download
M components/sessions/core/session_backend.h View 4 chunks +6 lines, -5 lines 0 comments Download
M components/sessions/core/session_backend.cc View 9 chunks +23 lines, -23 lines 0 comments Download
M components/sessions/core/session_backend_unittest.cc View 7 chunks +18 lines, -18 lines 0 comments Download
M components/sessions/core/session_service_commands.h View 1 chunk +1 line, -1 line 0 comments Download
M components/sessions/core/session_service_commands.cc View 4 chunks +12 lines, -12 lines 0 comments Download
M components/sessions/core/tab_restore_service_client.h View 1 chunk +0 lines, -1 line 0 comments Download
M components/sessions/ios/ios_serialized_navigation_builder.h View 2 chunks +1 line, -5 lines 0 comments Download
M components/sessions/ios/ios_serialized_navigation_builder.mm View 1 chunk +5 lines, -7 lines 0 comments Download
M ios/chrome/browser/sessions/tab_restore_service_delegate_impl_ios.mm View 1 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/tabs/tab.mm View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M ios/web/navigation/crw_session_controller.mm View 1 2 chunks +4 lines, -6 lines 0 comments Download
M ios/web/navigation/crw_session_controller+private_constructors.h View 1 2 chunks +4 lines, -2 lines 0 comments Download
M ios/web/navigation/crw_session_controller_unittest.mm View 1 2 7 chunks +13 lines, -11 lines 0 comments Download
M ios/web/navigation/navigation_manager_impl.h View 1 2 chunks +1 line, -2 lines 0 comments Download
M ios/web/navigation/navigation_manager_impl.mm View 1 1 chunk +1 line, -1 line 0 comments Download
M ios/web/net/crw_ssl_status_updater_unittest.mm View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 25 (18 generated)
Avi (use Gerrit)
sky/skuhne: sessions eugenebut: ios
3 years, 11 months ago (2016-12-31 22:57:49 UTC) #14
Eugene But (OOO till 7-30)
ios lgtm
3 years, 11 months ago (2017-01-03 17:25:39 UTC) #15
sky
LGTM https://codereview.chromium.org/2600583002/diff/40001/chrome/browser/sessions/session_service.h File chrome/browser/sessions/session_service.h (right): https://codereview.chromium.org/2600583002/diff/40001/chrome/browser/sessions/session_service.h#newcode14 chrome/browser/sessions/session_service.h:14: #include "base/memory/scoped_vector.h" Remove include?
3 years, 11 months ago (2017-01-03 17:29:34 UTC) #16
Avi (use Gerrit)
https://codereview.chromium.org/2600583002/diff/40001/chrome/browser/sessions/session_service.h File chrome/browser/sessions/session_service.h (right): https://codereview.chromium.org/2600583002/diff/40001/chrome/browser/sessions/session_service.h#newcode14 chrome/browser/sessions/session_service.h:14: #include "base/memory/scoped_vector.h" On 2017/01/03 17:29:34, sky (OOO) wrote: > ...
3 years, 11 months ago (2017-01-03 17:34:03 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2600583002/60001
3 years, 11 months ago (2017-01-03 17:36:16 UTC) #20
commit-bot: I haz the power
Committed patchset #4 (id:60001)
3 years, 11 months ago (2017-01-03 18:24:12 UTC) #23
commit-bot: I haz the power
3 years, 11 months ago (2017-01-03 18:27:40 UTC) #25
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/51f1cd9460c0e166805ceb6d47a4380408c9fae6
Cr-Commit-Position: refs/heads/master@{#441162}

Powered by Google App Engine
This is Rietveld 408576698