Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 2600533002: Added entry for thread information in the isolate view of the observatory. Current information show… (Closed)

Created:
4 years ago by bkonyi
Modified:
4 years ago
Reviewers:
zra, Cutch
CC:
reviews_dartlang.org, turnidge, rmacnak, Cutch, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Added entry for thread information in the isolate view of the observatory. Current information shown is: -List of active threads w/ their associated ID and task kinds -All zones active under a given thread, including their allocated capacity and current usage. BUG= R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/638a53e7150886984a33ded51e07040a7e352bef

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -2 lines) Patch
M runtime/observatory/lib/src/elements/css/shared.css View 1 chunk +6 lines, -0 lines 1 comment Download
M runtime/observatory/lib/src/elements/isolate_view.dart View 4 chunks +77 lines, -0 lines 0 comments Download
M runtime/observatory/lib/src/service/object.dart View 1 chunk +10 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
bkonyi
Here's the change that surfaces the zone memory information in the isolate view in the ...
4 years ago (2016-12-22 18:14:33 UTC) #2
Cutch
lgtm
4 years ago (2016-12-22 18:21:43 UTC) #3
bkonyi
4 years ago (2016-12-22 18:26:03 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
638a53e7150886984a33ded51e07040a7e352bef (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698