Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1181)

Unified Diff: runtime/observatory/lib/src/service/object.dart

Issue 2600533002: Added entry for thread information in the isolate view of the observatory. Current information show… (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/observatory/lib/src/service/object.dart
diff --git a/runtime/observatory/lib/src/service/object.dart b/runtime/observatory/lib/src/service/object.dart
index 3611ef82a0314e9c451f4c3800e6379eb75723f7..1ef7a5a8c55f63463ed66dd0f546a27a247415e3 100644
--- a/runtime/observatory/lib/src/service/object.dart
+++ b/runtime/observatory/lib/src/service/object.dart
@@ -3070,33 +3070,41 @@ class Sentinel extends ServiceObject implements M.Sentinel {
class Thread extends ServiceObject implements M.Thread {
M.ThreadKind get kind => _kind;
M.ThreadKind _kind;
+ String get kindString => _kindString;
+ String _kindString;
List<Zone> get zones => _zones;
final List<Zone> _zones = new List<Zone>();
Thread._empty(ServiceObjectOwner owner) : super._empty(owner);
void _update(Map map, bool mapIsRef) {
- String kindString = map['kind'];
+ String rawKind = map['kind'];
List<Map> zoneList = map['zones'];
- switch(kindString) {
+ switch(rawKind) {
case "kUnknownTask":
_kind = M.ThreadKind.unknownTask;
+ _kindString = 'unknown';
break;
case "kMutatorTask":
_kind = M.ThreadKind.mutatorTask;
+ _kindString = 'mutator';
break;
case "kCompilerTask":
_kind = M.ThreadKind.compilerTask;
+ _kindString = 'compiler';
break;
case "kSweeperTask":
_kind = M.ThreadKind.sweeperTask;
+ _kindString = 'sweeper';
break;
case "kMarkerTask":
_kind = M.ThreadKind.markerTask;
+ _kindString = 'marker';
break;
case "kFinalizerTask":
_kind = M.ThreadKind.finalizerTask;
+ _kindString = 'finalizer';
break;
default:
assert(false);

Powered by Google App Engine
This is Rietveld 408576698