Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Issue 2600473003: Re-enable FocusRestore/FocusRestoreOnTabSwitch in FindInPageTest for Linux_AURA (Closed)

Created:
3 years, 12 months ago by Qiang(Joe) Xu
Modified:
3 years, 11 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-enable FocusRestore/FocusRestoreOnTabSwitch in FindInPageTest for Linux_AURA Changes: Because now ui_test_utils::BringBrowserWindowToFront now supports activation waiter, let us reopen these tests for Linux_aura. BUG=163931 TEST=automated tests Committed: https://crrev.com/dbc0a009ff5e85a399cd8e5bff58441f96a595c7 Cr-Commit-Position: refs/heads/master@{#441291}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -18 lines) Patch
M chrome/browser/ui/views/find_bar_views_interactive_uitest.cc View 2 chunks +2 lines, -18 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
Qiang(Joe) Xu
Hi sky@, please take a look, thanks!
3 years, 12 months ago (2016-12-23 06:54:17 UTC) #7
sky
LGTM
3 years, 11 months ago (2017-01-03 18:54:18 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2600473003/1
3 years, 11 months ago (2017-01-04 01:36:06 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 11 months ago (2017-01-04 02:14:03 UTC) #13
commit-bot: I haz the power
3 years, 11 months ago (2017-01-04 02:18:05 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dbc0a009ff5e85a399cd8e5bff58441f96a595c7
Cr-Commit-Position: refs/heads/master@{#441291}

Powered by Google App Engine
This is Rietveld 408576698