Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 2600453004: Enable testRemovingTransientObjectHolders (Closed)

Created:
3 years, 12 months ago by boliu
Modified:
3 years, 12 months ago
Reviewers:
jbudorick
CC:
chromium-reviews, jam, darin-cc_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable testRemovingTransientObjectHolders Theory is test was disabled due to infra problems, not test itself. See bug for more details. BUG=673300 TBR=jbudorick Committed: https://crrev.com/9199b2b8a8520dcb0625e46d95cf02221bba69b9 Cr-Commit-Position: refs/heads/master@{#440520}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M content/public/android/javatests/src/org/chromium/content/browser/JavaBridgeChildFrameTest.java View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
boliu
3 years, 12 months ago (2016-12-22 21:59:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2600453004/1
3 years, 12 months ago (2016-12-22 22:00:19 UTC) #5
jbudorick
lgtm Given the flake timing, this was almost certainly due to infra issues.
3 years, 12 months ago (2016-12-22 22:00:41 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 12 months ago (2016-12-22 22:18:09 UTC) #9
commit-bot: I haz the power
3 years, 12 months ago (2016-12-22 22:21:09 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9199b2b8a8520dcb0625e46d95cf02221bba69b9
Cr-Commit-Position: refs/heads/master@{#440520}

Powered by Google App Engine
This is Rietveld 408576698