Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issue 2600453002: Fix some flaky IME tests caused by incorrect selection update (Closed)

Created:
4 years ago by yabinh
Modified:
4 years ago
CC:
chromium-reviews, jam, darin-cc_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix some flaky IME tests caused by incorrect selection update Some IME tests are flaky because of wrong selection update. We suspect it's because sometimes when we focus on input_text, the selection update comes after reseting the state. We should wait to ensure the correct order. BUG=628964 Committed: https://crrev.com/6a72722a3b04df4326bbf805676fca794fe33906 Cr-Commit-Position: refs/heads/master@{#440381}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java View 1 chunk +1 line, -0 lines 1 comment Download

Messages

Total messages: 14 (9 generated)
yabinh
PTAL, thanks!
4 years ago (2016-12-22 09:35:46 UTC) #4
Changwan Ryu
lgtm, thanks! https://codereview.chromium.org/2600453002/diff/1/content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java File content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java (right): https://codereview.chromium.org/2600453002/diff/1/content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java#newcode97 content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java:97: waitAndVerifyUpdateSelection(0, 0, 0, -1, -1); RenderWidget::resetInputMethod() indeed ...
4 years ago (2016-12-22 10:01:39 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2600453002/1
4 years ago (2016-12-22 11:18:40 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-22 11:22:35 UTC) #12
commit-bot: I haz the power
4 years ago (2016-12-22 11:25:12 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6a72722a3b04df4326bbf805676fca794fe33906
Cr-Commit-Position: refs/heads/master@{#440381}

Powered by Google App Engine
This is Rietveld 408576698