Source/modules/crypto/CryptoResultImpl.h - Issue 26004002: Decouple ScriptPromise creation from ScriptPromiseResolver.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/crypto/CryptoResultImpl.h

Issue 26004002: Decouple ScriptPromise creation from ScriptPromiseResolver. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: rebase Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/modules/crypto/CryptoResultImpl.h

diff --git a/Source/modules/crypto/CryptoResultImpl.h b/Source/modules/crypto/CryptoResultImpl.h

index 707b546655a26775545497ca542b905394587e5a..a363e9e69c0fd0d6acbce8f8b1855425beba6788 100644

--- a/Source/modules/crypto/CryptoResultImpl.h

+++ b/Source/modules/crypto/CryptoResultImpl.h

@@ -60,6 +60,7 @@ private:

CryptoResultImpl();

void finish();

+ ScriptPromise m_promise;

abarth-chromium 2013/10/11 18:18:02 Does this create a memory leak? If CryptoResult i

yhirano 2013/10/14 02:49:53 Done.

RefPtr<ScriptPromiseResolver> m_promiseResolver;

bool m_finished;

};

« Source/bindings/v8/ScriptPromise.h ('K') | « Source/core/css/FontFaceSet.cpp ('k') | Source/modules/crypto/CryptoResultImpl.cpp » ('j') | no next file with comments »