Source/modules/crypto/CryptoResultImpl.h - Issue 26004002: Decouple ScriptPromise creation from ScriptPromiseResolver.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/modules/crypto/CryptoResultImpl.h

Issue 26004002: Decouple ScriptPromise creation from ScriptPromiseResolver. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: rebase Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2013 Google Inc. All rights reserved.	2 * Copyright (C) 2013 Google Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions are	5 * modification, are permitted provided that the following conditions are

6 * met:	6 * met:

7 *	7 *

8 * * Redistributions of source code must retain the above copyright	8 * * Redistributions of source code must retain the above copyright

9 * notice, this list of conditions and the following disclaimer.	9 * notice, this list of conditions and the following disclaimer.

10 * * Redistributions in binary form must reproduce the above	10 * * Redistributions in binary form must reproduce the above

(...skipping 42 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
53 virtual void completeWithBoolean(bool) OVERRIDE;	53 virtual void completeWithBoolean(bool) OVERRIDE;

54 virtual void completeWithKey(const WebKit::WebCryptoKey&) OVERRIDE;	54 virtual void completeWithKey(const WebKit::WebCryptoKey&) OVERRIDE;

55 virtual void completeWithKeyPair(const WebKit::WebCryptoKey& publicKey, cons t WebKit::WebCryptoKey& privateKey) OVERRIDE;	55 virtual void completeWithKeyPair(const WebKit::WebCryptoKey& publicKey, cons t WebKit::WebCryptoKey& privateKey) OVERRIDE;

56	56

57 ScriptPromise promise();	57 ScriptPromise promise();

58	58

59 private:	59 private:

60 CryptoResultImpl();	60 CryptoResultImpl();

61 void finish();	61 void finish();

62	62

	63 ScriptPromise m_promise;
	abarth-chromium 2013/10/11 18:18:02 Does this create a memory leak? If CryptoResult i Does this create a memory leak? If CryptoResult is holding m_promise alive, is it possible that m_promise is holding CryptoResult alive? Can we remove this member? yhirano 2013/10/14 02:49:53 Done. Show quoted text On 2013/10/11 18:18:02, abarth wrote: > Does this create a memory leak? If CryptoResult is holding m_promise alive, is > it possible that m_promise is holding CryptoResult alive? Can we remove this > member? Done.
63 RefPtr<ScriptPromiseResolver> m_promiseResolver;	64 RefPtr<ScriptPromiseResolver> m_promiseResolver;

64 bool m_finished;	65 bool m_finished;

65 };	66 };

66	67

67 } // namespace WebCore	68 } // namespace WebCore

68	69

69 #endif	70 #endif

OLD	NEW

« Source/bindings/v8/ScriptPromise.h ('K') | « Source/core/css/FontFaceSet.cpp ('k') | Source/modules/crypto/CryptoResultImpl.cpp » ('j') | no next file with comments »