Use explicit WebString <-> string16 conversion methods in storage API files (2)

Use explicit WebString <-> string16 conversion methods in storage API files (2)

Some remaining ones in cache_storage and dom_storage

BUG=667131
Committed: https://crrev.com/d33eda3411eebc14ae925546b445eff1655a2988
Cr-Commit-Position: refs/heads/master@{#441600}

[kinuko, 2016-12-28 12:23:44]

The CQ bit was checked by kinuko@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-28 12:23:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-28 13:10:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-28 13:10:02]

Dry run: This issue passed the CQ dry run.

[kinuko, 2016-12-29 05:42:40]

Description was changed from

==========
Use explicit WebString <-> string16 conversion methods in storage API files (2)

Some remaining ones in cache_storage and dom_storage

BUG=667131
==========

to

==========
Use explicit WebString <-> string16 conversion methods in storage API files (2)

Some remaining ones in cache_storage and dom_storage

BUG=667131
==========

[kinuko, 2016-12-29 05:42:40]

kinuko@chromium.org changed reviewers:
+ jsbell@chromium.org, michaeln@chromium.org

[jsbell, 2017-01-03 18:08:43]

lgtm but...

https://codereview.chromium.org/2600383002/diff/1/content/renderer/cache_stor...
File content/renderer/cache_storage/cache_storage_dispatcher.cc (right):

https://codereview.chromium.org/2600383002/diff/1/content/renderer/cache_stor...
content/renderer/cache_storage/cache_storage_dispatcher.cc:318: [](const
base::string16& s) { return WebString::fromUTF16(s); });
Does this need to be a lambda or can we just pass &WebString::fromUTF16 ?

https://codereview.chromium.org/2600383002/diff/1/content/renderer/cache_stor...
content/renderer/cache_storage/cache_storage_dispatcher.cc:645: [](const
std::string& s) { return WebString::fromLatin1(s); });
just pass &WebString::fromLatin1 ?

[kinuko, 2017-01-05 05:26:22]

On 2017/01/03 18:08:43, jsbell wrote:
> lgtm but...
> 
>
https://codereview.chromium.org/2600383002/diff/1/content/renderer/cache_stor...
> File content/renderer/cache_storage/cache_storage_dispatcher.cc (right):
> 
>
https://codereview.chromium.org/2600383002/diff/1/content/renderer/cache_stor...
> content/renderer/cache_storage/cache_storage_dispatcher.cc:318: [](const
> base::string16& s) { return WebString::fromUTF16(s); });
> Does this need to be a lambda or can we just pass &WebString::fromUTF16 ?
> 
>
https://codereview.chromium.org/2600383002/diff/1/content/renderer/cache_stor...
> content/renderer/cache_storage/cache_storage_dispatcher.cc:645: [](const
> std::string& s) { return WebString::fromLatin1(s); });
> just pass &WebString::fromLatin1 ?

Both methods are overloaded, we need casting to make it work... which could be
uglier/longer than using lambda :(

[kinuko, 2017-01-05 05:26:29]

The CQ bit was checked by kinuko@chromium.org

[commit-bot: I haz the power, 2017-01-05 05:26:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-05 06:40:28]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1483593989834550, "parent_rev":
"4bd117e2caa4b5e8df0199a780110d442b6a45a8", "commit_rev":
"b47ad5ac79beaf26eef852c365efe9f3de67bae2"}

[commit-bot: I haz the power, 2017-01-05 06:41:02]

Description was changed from

==========
Use explicit WebString <-> string16 conversion methods in storage API files (2)

Some remaining ones in cache_storage and dom_storage

BUG=667131
==========

to

==========
Use explicit WebString <-> string16 conversion methods in storage API files (2)

Some remaining ones in cache_storage and dom_storage

BUG=667131

Review-Url: https://codereview.chromium.org/2600383002
==========

[commit-bot: I haz the power, 2017-01-05 06:41:03]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2017-01-05 06:43:34]

Description was changed from

==========
Use explicit WebString <-> string16 conversion methods in storage API files (2)

Some remaining ones in cache_storage and dom_storage

BUG=667131

Review-Url: https://codereview.chromium.org/2600383002
==========

to

==========
Use explicit WebString <-> string16 conversion methods in storage API files (2)

Some remaining ones in cache_storage and dom_storage

BUG=667131

Committed: https://crrev.com/d33eda3411eebc14ae925546b445eff1655a2988
Cr-Commit-Position: refs/heads/master@{#441600}
==========

[commit-bot: I haz the power, 2017-01-05 06:43:37]

Patchset 1 (id:??) landed as
https://crrev.com/d33eda3411eebc14ae925546b445eff1655a2988
Cr-Commit-Position: refs/heads/master@{#441600}

[jsbell, 2017-01-05 17:40:44]

On 2017/01/05 05:26:22, kinuko wrote:
> Both methods are overloaded, we need casting to make it work... which could be
> uglier/longer than using lambda :(

Ah, makes sense then. Thanks for explaining!