Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(397)

Issue 2600353002: base: Fix build issues on trusty and jessie. (Closed)

Created:
3 years, 11 months ago by reveman
Modified:
3 years, 11 months ago
Reviewers:
danakj
CC:
chromium-reviews, vmpstr+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

base: Fix build issues on trusty and jessie. The GCC/libstdc++ versions used on trusty and jessie are missing std::is_trivially_copyable. Include these GLIBCXX versions in the OLD_EXPERIMENTAL_GLIBCXX fallback to allow chromium to be built with the jessie sysroot or without a sysroot on trusty. BUG=555754 Committed: https://crrev.com/bf74cf1b649e20b4a60d2f5602db03697c8a82ef Cr-Commit-Position: refs/heads/master@{#440971}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -4 lines) Patch
M base/template_util.h View 1 chunk +7 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
reveman
3 years, 11 months ago (2016-12-28 11:13:50 UTC) #2
danakj
lol gcc pls. LGTM if this passes bots
3 years, 11 months ago (2016-12-29 16:05:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2600353002/1
3 years, 11 months ago (2016-12-29 18:12:43 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 11 months ago (2016-12-29 18:16:38 UTC) #12
commit-bot: I haz the power
3 years, 11 months ago (2017-01-02 15:52:46 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bf74cf1b649e20b4a60d2f5602db03697c8a82ef
Cr-Commit-Position: refs/heads/master@{#440971}

Powered by Google App Engine
This is Rietveld 408576698