Disable some PaintPropertyTreeBuilder features for SPv1 SlimmingPaintInvalidation

Disable some PaintPropertyTreeBuilder features for SPv1 SlimmingPaintInvalidation

Disable the following features for SPv1 SlimmingPaintInvalidation:
- directCompositingReasons in transform nodes,
- preserve3D/flattenInheritedTransforms in transform nodes,
- effect nodes.

The features have some paint property under-invalidation bugs which
should not block SlimmingPaintInvalidation.

BUG=646176, 677239, 677241
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

[Xianzhu, 2016-12-28 06:36:54]

Description was changed from

==========
Disable some PaintPropertyTreeBuilder features for SlimmingPaintInvalidation

Disable the following features for SlimmingPaintInvalidation:
- directCompositingReasons in transform nodes,
- effect nodes.

The features have some paint property under-invalidation bugs which
should not block SlimmingPaintInvalidation.

BUG=646176
==========

to

==========
Disable some PaintPropertyTreeBuilder features for SlimmingPaintInvalidation

Disable the following features for SlimmingPaintInvalidation:
- directCompositingReasons in transform nodes,
- effect nodes.

The features have some paint property under-invalidation bugs which
should not block SlimmingPaintInvalidation.

BUG=646176
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[Xianzhu, 2016-12-28 06:36:56]

The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-28 06:36:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xianzhu, 2016-12-28 06:48:12]

Description was changed from

==========
Disable some PaintPropertyTreeBuilder features for SlimmingPaintInvalidation

Disable the following features for SlimmingPaintInvalidation:
- directCompositingReasons in transform nodes,
- effect nodes.

The features have some paint property under-invalidation bugs which
should not block SlimmingPaintInvalidation.

BUG=646176
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Disable some PaintPropertyTreeBuilder features for SlimmingPaintInvalidation

Disable the following features for SlimmingPaintInvalidation:
- directCompositingReasons in transform nodes,
- effect nodes.

The features have some paint property under-invalidation bugs which
should not block SlimmingPaintInvalidation.

BUG=646176,677239,677241
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[Xianzhu, 2016-12-28 07:01:46]

The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-28 07:01:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xianzhu, 2016-12-28 07:04:07]

The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-28 07:04:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-28 08:10:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-28 08:10:38]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Xianzhu, 2016-12-28 17:51:39]

Description was changed from

==========
Disable some PaintPropertyTreeBuilder features for SlimmingPaintInvalidation

Disable the following features for SlimmingPaintInvalidation:
- directCompositingReasons in transform nodes,
- effect nodes.

The features have some paint property under-invalidation bugs which
should not block SlimmingPaintInvalidation.

BUG=646176,677239,677241
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Disable some PaintPropertyTreeBuilder features for SPv1
SlimmingPaintInvalidation

Disable the following features for SlimmingPaintInvalidation:
- directCompositingReasons in transform nodes,
- effect nodes.

The features have some paint property under-invalidation bugs which
should not block SlimmingPaintInvalidation.

BUG=646176,677239,677241
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[Xianzhu, 2016-12-28 18:09:29]

The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-28 18:09:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xianzhu, 2016-12-28 18:10:21]

Description was changed from

==========
Disable some PaintPropertyTreeBuilder features for SPv1
SlimmingPaintInvalidation

Disable the following features for SlimmingPaintInvalidation:
- directCompositingReasons in transform nodes,
- effect nodes.

The features have some paint property under-invalidation bugs which
should not block SlimmingPaintInvalidation.

BUG=646176,677239,677241
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Disable some PaintPropertyTreeBuilder features for SPv1
SlimmingPaintInvalidation

Disable the following features for SPv1 SlimmingPaintInvalidation:
- directCompositingReasons in transform nodes,
- preserve3D/flattenInheritedTransforms in transform nodes,
- effect nodes.

The features have some paint property under-invalidation bugs which
should not block SlimmingPaintInvalidation.

BUG=646176,677239,677241
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[Xianzhu, 2016-12-28 18:10:33]

wangxianzhu@chromium.org changed reviewers:
+ chrishtr@chromium.org

[chrishtr, 2016-12-28 18:15:18]

https://codereview.chromium.org/2600333002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp (right):

https://codereview.chromium.org/2600333002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp:369:
needsTransformNode |= style.preserves3D();
Are you sure preserve-3D is not required for SlimmingPaintInvalidation?

[Xianzhu, 2016-12-28 18:25:29]

https://codereview.chromium.org/2600333002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp (right):

https://codereview.chromium.org/2600333002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp:369:
needsTransformNode |= style.preserves3D();
On 2016/12/28 18:15:18, chrishtr wrote:
> Are you sure preserve-3D is not required for SlimmingPaintInvalidation?

Yes. GeometryMapper doesn't use FlattenInheritedTransform.

[chrishtr, 2016-12-28 19:28:03]

Per offline conversation, we agreed to drop this CL in favor of just fixing the
bugs.