Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1172)

Issue 2600263002: [ios] Fixed GetIndexForOffset for pending transient items. (Closed)

Created:
3 years, 12 months ago by Eugene But (OOO till 7-30)
Modified:
3 years, 11 months ago
Reviewers:
kkhorimoto
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ios] Fixed GetIndexForOffset for pending transient items. GetIndexForOffset() should decrease resulting index by 1 for pending transient items to allow going back from interstitials that were added to the middle of the stack. BUG=677190 Committed: https://crrev.com/8f276d123db9ccd82569be7cb8658fde3999ae59 Cr-Commit-Position: refs/heads/master@{#440808}

Patch Set 1 #

Patch Set 2 : Fixed tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -6 lines) Patch
M ios/web/navigation/navigation_manager_impl.mm View 1 chunk +4 lines, -3 lines 0 comments Download
M ios/web/navigation/navigation_manager_impl_unittest.mm View 1 2 chunks +46 lines, -3 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
Eugene But (OOO till 7-30)
3 years, 12 months ago (2016-12-27 21:51:49 UTC) #2
kkhorimoto
lgtm
3 years, 12 months ago (2016-12-27 22:16:49 UTC) #3
Eugene But (OOO till 7-30)
Thanks for quick review!
3 years, 12 months ago (2016-12-27 22:17:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2600263002/1
3 years, 12 months ago (2016-12-27 22:18:09 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/129515)
3 years, 12 months ago (2016-12-27 22:36:37 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2600263002/20001
3 years, 12 months ago (2016-12-27 23:35:10 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
3 years, 12 months ago (2016-12-27 23:45:14 UTC) #14
commit-bot: I haz the power
3 years, 11 months ago (2017-01-02 15:47:54 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8f276d123db9ccd82569be7cb8658fde3999ae59
Cr-Commit-Position: refs/heads/master@{#440808}

Powered by Google App Engine
This is Rietveld 408576698