Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 2600233002: Remove the PlzNavigate browser_tests filter as all tests are now passing. (Closed)

Created:
3 years, 11 months ago by jam
Modified:
3 years, 11 months ago
Reviewers:
nasko
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove the PlzNavigate browser_tests filter as all tests are now passing. ChromeServiceWorkerTest.FallbackMainResourceRequestWhenJSDisabled was already fixed but it snuck back in from a bad merge. Camille fixed the PageLoadMetricsBrowserTest failures in r440646. BUG=504347 Committed: https://crrev.com/356cd8379b3f2b06bd17716f88a2568791b4c60a Cr-Commit-Position: refs/heads/master@{#440774}

Patch Set 1 #

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -20 lines) Patch
M testing/buildbot/chromium.fyi.json View 2 chunks +0 lines, -9 lines 0 comments Download
M testing/buildbot/chromium.linux.json View 1 2 chunks +2 lines, -4 lines 0 comments Download
M testing/buildbot/filters/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D testing/buildbot/filters/browser-side-navigation.linux.browser_tests.filter View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
jam
3 years, 11 months ago (2016-12-27 16:54:04 UTC) #5
nasko
Nice to be at this stage! LGTM
3 years, 11 months ago (2016-12-27 17:51:13 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2600233002/20001
3 years, 11 months ago (2016-12-27 17:58:43 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
3 years, 11 months ago (2016-12-27 18:58:06 UTC) #14
commit-bot: I haz the power
3 years, 11 months ago (2017-01-02 15:46:45 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/356cd8379b3f2b06bd17716f88a2568791b4c60a
Cr-Commit-Position: refs/heads/master@{#440774}

Powered by Google App Engine
This is Rietveld 408576698