[turbofan] Remove virtual methods from CodeAssembler.

[turbofan] Remove virtual methods from CodeAssembler.

... and add explicit CallPrologue/CallEpilogue callbacks to CodeAssemblerState instead.
This will allow IntepreterAssembler to use any other helper assembler.

TBR=rmcilroy@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2600183004
Cr-Commit-Position: refs/heads/master@{#41973}
Committed: https://chromium.googlesource.com/v8/v8/+/d083833499e2be9518d226d75ee6183ad3adc67b

[Igor Sheludko, 2016-12-28 15:22:28]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-28 15:22:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Igor Sheludko, 2016-12-28 15:22:38]

ishell@chromium.org changed reviewers:
+ epertoso@chromium.org

[Igor Sheludko, 2016-12-28 15:22:38]

PTAL

https://codereview.chromium.org/2600183004/diff/1/src/compiler/code-assembler.cc
File src/compiler/code-assembler.cc (left):

https://codereview.chromium.org/2600183004/diff/1/src/compiler/code-assembler...
src/compiler/code-assembler.cc:453: CallPrologue();
Drive-by fix.

[epertoso, 2016-12-28 15:29:27]

lgtm

[Igor Sheludko, 2016-12-28 15:29:53]

Description was changed from

==========
[turbofan] Remove virtual methods from CodeAssembler.

... and add explicit CallPrologue/CallEpilogue callbacks to CodeAssemblerState
instead.
This will allow IntepreterAssembler to use any other helper assembler.

BUG=
==========

to

==========
[turbofan] Remove virtual methods from CodeAssembler.

... and add explicit CallPrologue/CallEpilogue callbacks to CodeAssemblerState
instead.
This will allow IntepreterAssembler to use any other helper assembler.

TBR=rmcilroy@chromium.org
BUG=
==========

[Igor Sheludko, 2016-12-28 15:33:34]

The CQ bit was unchecked by ishell@chromium.org

[Igor Sheludko, 2016-12-28 15:33:37]

The CQ bit was checked by ishell@chromium.org

[commit-bot: I haz the power, 2016-12-28 15:33:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-28 15:47:34]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1482939217569190, "parent_rev":
"505cfdd84d3e6f9859c2dd51fa8e27611164e4d3", "commit_rev":
"d083833499e2be9518d226d75ee6183ad3adc67b"}

[commit-bot: I haz the power, 2016-12-28 15:47:39]

Description was changed from

==========
[turbofan] Remove virtual methods from CodeAssembler.

... and add explicit CallPrologue/CallEpilogue callbacks to CodeAssemblerState
instead.
This will allow IntepreterAssembler to use any other helper assembler.

TBR=rmcilroy@chromium.org
BUG=
==========

to

==========
[turbofan] Remove virtual methods from CodeAssembler.

... and add explicit CallPrologue/CallEpilogue callbacks to CodeAssemblerState
instead.
This will allow IntepreterAssembler to use any other helper assembler.

TBR=rmcilroy@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2600183004
Cr-Commit-Position: refs/heads/master@{#41973}
Committed:
https://chromium.googlesource.com/v8/v8/+/d083833499e2be9518d226d75ee6183ad3a...
==========

[commit-bot: I haz the power, 2016-12-28 15:47:40]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/d083833499e2be9518d226d75ee6183ad3a...

[mvstanton, 2016-12-29 08:02:57]

mvstanton@chromium.org changed reviewers:
+ mvstanton@chromium.org

[mvstanton, 2016-12-29 08:02:57]

W00t! Thanks Igor!

[rmcilroy, 2017-01-03 09:37:50]

rmcilroy@chromium.org changed reviewers:
+ rmcilroy@chromium.org

[rmcilroy, 2017-01-03 09:37:51]

LGTM, thanks.

https://codereview.chromium.org/2600183004/diff/1/src/compiler/code-assembler.cc
File src/compiler/code-assembler.cc (left):

https://codereview.chromium.org/2600183004/diff/1/src/compiler/code-assembler...
src/compiler/code-assembler.cc:453: CallPrologue();
On 2016/12/28 15:22:38, Igor Sheludko wrote:
> Drive-by fix.

Thanks!