Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(880)

Issue 2600183002: Clean up quic_simple_client_bin.cc to sync with quic_client_bin.cc (Closed)

Created:
3 years, 12 months ago by Ryan Hamilton
Modified:
3 years, 11 months ago
Reviewers:
Jana
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clean up quic_simple_client_bin.cc to sync with quic_client_bin.cc Committed: https://crrev.com/2239d36e7ffe72bf4a261441fdd7e1d11f790455 Cr-Commit-Position: refs/heads/master@{#440920}

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -71 lines) Patch
M net/tools/quic/quic_client_bin.cc View 4 chunks +3 lines, -4 lines 0 comments Download
M net/tools/quic/quic_simple_client.h View 2 chunks +3 lines, -9 lines 0 comments Download
M net/tools/quic/quic_simple_client.cc View 4 chunks +12 lines, -25 lines 0 comments Download
M net/tools/quic/quic_simple_client_bin.cc View 8 chunks +21 lines, -32 lines 0 comments Download
M net/tools/quic/quic_simple_client_test.cc View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 18 (12 generated)
Ryan Hamilton
3 years, 12 months ago (2016-12-27 04:45:13 UTC) #2
Jana
lgtm
3 years, 12 months ago (2016-12-27 20:52:05 UTC) #3
commit-bot: I haz the power
This CL has an open dependency (Issue 2603723002 Patch 80001). Please resolve the dependency and ...
3 years, 12 months ago (2016-12-27 20:54:24 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2600183002/40001
3 years, 11 months ago (2016-12-29 01:19:22 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
3 years, 11 months ago (2016-12-29 01:23:51 UTC) #16
commit-bot: I haz the power
3 years, 11 months ago (2017-01-02 15:51:17 UTC) #18
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/2239d36e7ffe72bf4a261441fdd7e1d11f790455
Cr-Commit-Position: refs/heads/master@{#440920}

Powered by Google App Engine
This is Rietveld 408576698