Fix memory leak in file service.

Fix memory leak in file service.

BUG=None

Committed: https://crrev.com/f347d451203eb1b51cf90fc31076fe232ffb05df
Cr-Commit-Position: refs/heads/master@{#440803}

[Marijn Kruisselbrink, 2016-12-27 22:18:31]

The CQ bit was checked by mek@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-27 22:18:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Marijn Kruisselbrink, 2016-12-27 22:22:00]

mek@chromium.org changed reviewers:
+ erg@chromium.org, rockot@chromium.org

[Marijn Kruisselbrink, 2016-12-27 22:22:01]

rockot: can you take a look since erg@ is OOO?

This seems to most straight-forward way of fixing this memory leak. One thing
I'm not sure about though is if the previous behavior where on destruction of
the FileService all FileSystem instances were destroyed/disconnected as well was
intentional or not. If that behavior is something we need to keep then
FileSystemObjects will likely need to be a bit more complicated rather than
relying on StrongBinding (since we don't seem to have such a thing as a
StrongBindingSet, which from previous discussion around this specific memory
leak seems intentional?)

[commit-bot: I haz the power, 2016-12-27 23:01:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-27 23:01:54]

Dry run: This issue passed the CQ dry run.

[Ken Rockot(use gerrit already), 2016-12-27 23:12:27]

On 2016/12/27 at 22:22:01, mek wrote:
> rockot: can you take a look since erg@ is OOO?
> 
> This seems to most straight-forward way of fixing this memory leak. One thing
I'm not sure about though is if the previous behavior where on destruction of
the FileService all FileSystem instances were destroyed/disconnected as well was
intentional or not. If that behavior is something we need to keep then
FileSystemObjects will likely need to be a bit more complicated rather than
relying on StrongBinding (since we don't seem to have such a thing as a
StrongBindingSet, which from previous discussion around this specific memory
leak seems intentional?)

LGTM. I don't believe the slight change to binding lifetime will be an issue.
Note that any FileService instance already lives as long as its BrowserContext
anyway.

[Marijn Kruisselbrink, 2016-12-27 23:22:49]

The CQ bit was checked by mek@chromium.org

[commit-bot: I haz the power, 2016-12-27 23:23:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-27 23:26:40]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1482880969268760, "parent_rev":
"987b1efc82b75fbba8329e8d8a613212b60359ee", "commit_rev":
"b61d4eb60653cfb5c17cffefe6ddbad4ebc6a4cd"}

[commit-bot: I haz the power, 2016-12-27 23:27:11]

Description was changed from

==========
Fix memory leak in file service.

BUG=None
==========

to

==========
Fix memory leak in file service.

BUG=None

Review-Url: https://codereview.chromium.org/2600153003
==========

[commit-bot: I haz the power, 2016-12-27 23:27:12]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2017-01-02 15:47:45]

Description was changed from

==========
Fix memory leak in file service.

BUG=None

Review-Url: https://codereview.chromium.org/2600153003
==========

to

==========
Fix memory leak in file service.

BUG=None

Committed: https://crrev.com/f347d451203eb1b51cf90fc31076fe232ffb05df
Cr-Commit-Position: refs/heads/master@{#440803}
==========

[commit-bot: I haz the power, 2017-01-02 15:47:46]

Patchset 1 (id:??) landed as
https://crrev.com/f347d451203eb1b51cf90fc31076fe232ffb05df
Cr-Commit-Position: refs/heads/master@{#440803}