Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 2600123002: Initialize member array field. (Closed)

Created:
3 years, 12 months ago by apisarev
Modified:
3 years, 11 months ago
Reviewers:
skobes
CC:
chromium-reviews, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Initialize member array field. In RuleData we have array field, which is not initialized at construction of the object. And after object constructed, we iterate through this array by pointer. This code look dangerous and MSan detect this problem. To be safe during this iteration need initialize this array. It was done. R=skobes BUG=None Committed: https://crrev.com/2d88572a7e87c280d1b1fdd222ebec771b8be482 Cr-Commit-Position: refs/heads/master@{#440838}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M third_party/WebKit/Source/core/css/RuleSet.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
apisarev
3 years, 12 months ago (2016-12-26 15:41:37 UTC) #2
skobes
lgtm
3 years, 12 months ago (2016-12-27 17:45:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2600123002/1
3 years, 12 months ago (2016-12-28 08:00:08 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 12 months ago (2016-12-28 09:21:20 UTC) #8
commit-bot: I haz the power
3 years, 11 months ago (2017-01-02 15:48:42 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2d88572a7e87c280d1b1fdd222ebec771b8be482
Cr-Commit-Position: refs/heads/master@{#440838}

Powered by Google App Engine
This is Rietveld 408576698