Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5896)

Unified Diff: chrome/browser/autocomplete/autocomplete_popup_view_mac.h

Issue 260008: [Mac] Cmd-Return in the omnibox should revert the omnibox text back to its or... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/autocomplete/autocomplete_popup_view_mac.h
===================================================================
--- chrome/browser/autocomplete/autocomplete_popup_view_mac.h (revision 29719)
+++ chrome/browser/autocomplete/autocomplete_popup_view_mac.h (working copy)
@@ -69,10 +69,10 @@
// Returns the popup's model.
virtual AutocompletePopupModel* GetModel();
- // Updates model_'s sense of selected line from the UI before
- // calling edit_view_'s AcceptInput(). Used by internal Objective-C
- // helper object.
- void AcceptInput();
+ // Called when the user clicks an item. Opens the hovered item and
+ // potentially dismisses the popup without formally selecting anything in the
+ // model.
+ void OnClick();
// Called when the user middle-clicks an item. Opens the hovered
// item in a background tab.
@@ -109,6 +109,12 @@
// Create the popup_ instance if needed.
void CreatePopupIfNeeded();
+ // Opens the URL corresponding to the given |row|. If |force_background| is
+ // true, forces the URL to open in a background tab. Otherwise, determines
+ // the proper window open disposition from the modifier flags on |[NSEvent
+ // currentEvent]|.
+ void OpenURLForRow(int row, bool force_background);
+
scoped_ptr<AutocompletePopupModel> model_;
AutocompleteEditViewMac* edit_view_;
const BubblePositioner* bubble_positioner_; // owned by toolbar controller
« no previous file with comments | « chrome/browser/autocomplete/autocomplete_edit_view_mac.mm ('k') | chrome/browser/autocomplete/autocomplete_popup_view_mac.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698