Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6095)

Unified Diff: chrome/browser/autocomplete/autocomplete_edit_view_mac.mm

Issue 260008: [Mac] Cmd-Return in the omnibox should revert the omnibox text back to its or... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/autocomplete/autocomplete_popup_view_mac.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/autocomplete/autocomplete_edit_view_mac.mm
===================================================================
--- chrome/browser/autocomplete/autocomplete_edit_view_mac.mm (revision 29719)
+++ chrome/browser/autocomplete/autocomplete_edit_view_mac.mm (working copy)
@@ -825,6 +825,11 @@
WindowOpenDisposition disposition =
event_utils::WindowOpenDispositionFromNSEvent(event);
edit_view_->AcceptInput(disposition, false);
+ // Opening a URL in a background tab should also revert the omnibox contents
+ // to their original state. We cannot do a blanket revert in OpenURL()
+ // because middle-clicks also open in a new background tab, but those should
+ // not revert the omnibox text.
+ edit_view_->RevertAll();
return YES;
}
« no previous file with comments | « no previous file | chrome/browser/autocomplete/autocomplete_popup_view_mac.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698