net: change ImportFromPKCS12() to take a PK11SlotInfo*

net: change ImportFromPKCS12() to take a PK11SlotInfo*

This is the first step to get rid of deprecated CryptoModule methods in
NSSCertDatabase class and then later get rid of CryptoModule
abstraction.

BUG=None
TEST=net_unittests
R=mattm@chromium.org,jochen@chromium.org,armansito@chromium.org
TBR=dbeam@chromium.org

Review-Url: https://codereview.chromium.org/2600053002
Cr-Commit-Position: refs/heads/master@{#443533}
Committed: https://chromium.googlesource.com/chromium/src/+/f58077a1aed579173033500375bdf51859d27836

[tfarina, 2016-12-25 15:11:42]

The CQ bit was checked by tfarina@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-25 15:11:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-25 15:26:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-25 15:26:42]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[tfarina, 2016-12-25 15:37:57]

The CQ bit was checked by tfarina@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-25 15:38:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-25 15:53:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-25 15:53:54]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[tfarina, 2016-12-25 18:51:56]

The CQ bit was checked by tfarina@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-25 18:51:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tfarina, 2016-12-25 19:20:27]

The CQ bit was checked by tfarina@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-25 19:20:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tfarina, 2016-12-25 19:33:15]

The CQ bit was checked by tfarina@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-25 19:33:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tfarina, 2016-12-25 19:48:12]

The CQ bit was checked by tfarina@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-25 19:48:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tfarina, 2016-12-25 19:57:52]

The CQ bit was checked by tfarina@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-25 19:58:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-25 20:39:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-25 20:39:48]

Dry run: This issue passed the CQ dry run.

[mattm, 2017-01-11 23:48:37]

lgtm, thanks!

[tfarina, 2017-01-12 11:41:15]

Adding owners:

jochen -> chrome
armansito -> chromeos/network/

[tfarina, 2017-01-12 11:44:23]

tfarina@chromium.org changed reviewers:
+ armansito@chromium.org, jochen@chromium.org

[jochen (gone - plz use gerrit), 2017-01-12 11:55:37]

lgtm

[tfarina, 2017-01-12 22:29:40]

The CQ bit was checked by tfarina@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-12 22:30:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-12 23:37:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-12 23:37:44]

Dry run: This issue passed the CQ dry run.

[armansito, 2017-01-13 06:53:00]

lgtm

[tfarina, 2017-01-13 11:10:05]

The CQ bit was checked by tfarina@chromium.org

[tfarina, 2017-01-13 11:10:06]

The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org,
mattm@chromium.org
Link to the patchset: https://codereview.chromium.org/2600053002/#ps150001
(title: "REBASE")

[commit-bot: I haz the power, 2017-01-13 11:10:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-13 11:16:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-13 11:16:34]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[tfarina, 2017-01-13 11:34:57]

tfarina@chromium.org changed reviewers:
+ dbeam@chromium.org

[tfarina, 2017-01-13 11:34:58]

TBRing Dan for chrome/browser/ui/webui/options/certificate_manager_handler.cc

[tfarina, 2017-01-13 11:35:30]

Description was changed from

==========
net: change ImportFromPKCS12() to take a PK11SlotInfo*

This is the first step to get rid of deprecated CryptoModule methods in
NSSCertDatabase class and then later get rid of CryptoModule
abstraction.

BUG=None
TEST=net_unittests
R=mattm@chromium.org
==========

to

==========
net: change ImportFromPKCS12() to take a PK11SlotInfo*

This is the first step to get rid of deprecated CryptoModule methods in
NSSCertDatabase class and then later get rid of CryptoModule
abstraction.

BUG=None
TEST=net_unittests
R=mattm@chromium.org,jochen@chromium.org,armansito@chromium.org
TBR=dbeam@chromium.org
==========

[tfarina, 2017-01-13 11:35:38]

The CQ bit was checked by tfarina@chromium.org

[commit-bot: I haz the power, 2017-01-13 11:35:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-13 11:40:12]

CQ is committing da patch.

Bot data: {"patchset_id": 150001, "attempt_start_ts": 1484307338704520,
"parent_rev": "63cfac9f60276d84701f8afe7ca1603f2ae1e575", "commit_rev":
"f58077a1aed579173033500375bdf51859d27836"}

[commit-bot: I haz the power, 2017-01-13 11:40:54]

Description was changed from

==========
net: change ImportFromPKCS12() to take a PK11SlotInfo*

This is the first step to get rid of deprecated CryptoModule methods in
NSSCertDatabase class and then later get rid of CryptoModule
abstraction.

BUG=None
TEST=net_unittests
R=mattm@chromium.org,jochen@chromium.org,armansito@chromium.org
TBR=dbeam@chromium.org
==========

to

==========
net: change ImportFromPKCS12() to take a PK11SlotInfo*

This is the first step to get rid of deprecated CryptoModule methods in
NSSCertDatabase class and then later get rid of CryptoModule
abstraction.

BUG=None
TEST=net_unittests
R=mattm@chromium.org,jochen@chromium.org,armansito@chromium.org
TBR=dbeam@chromium.org

Review-Url: https://codereview.chromium.org/2600053002
Cr-Commit-Position: refs/heads/master@{#443533}
Committed:
https://chromium.googlesource.com/chromium/src/+/f58077a1aed579173033500375bd...
==========

[commit-bot: I haz the power, 2017-01-13 11:40:56]

Committed patchset #9 (id:150001) as
https://chromium.googlesource.com/chromium/src/+/f58077a1aed579173033500375bd...