Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(758)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 260003006: Added a Isolate* parameter to Serializer::enabled(). (Closed)

Created:
6 years, 7 months ago by Sven Panne
Modified:
6 years, 7 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

Added a Isolate* parameter to Serializer::enabled(). This parameter will soon be used when a few pseudo-classes like Serializer are turned into real classes. The current CL is already big enough, untying our Gordian knot called "startup" will continue... BUG=359977 LOG=y R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21083

Patch Set 1 #

Total comments: 4

Patch Set 2 : Rebased. Feedback. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+231 lines, -176 lines) Patch
M src/arm/assembler-arm.h View 1 2 chunks +7 lines, -4 lines 0 comments Download
M src/arm/assembler-arm.cc View 10 chunks +20 lines, -15 lines 0 comments Download
M src/arm/codegen-arm.cc View 1 1 chunk +3 lines, -2 lines 0 comments Download
M src/arm/deoptimizer-arm.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/arm/full-codegen-arm.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M src/arm/lithium-arm.h View 1 3 chunks +6 lines, -2 lines 0 comments Download
M src/arm/lithium-arm.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/arm/macro-assembler-arm.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/arm/macro-assembler-arm.cc View 1 7 chunks +17 lines, -11 lines 0 comments Download
M src/arm64/assembler-arm64.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/arm64/assembler-arm64.cc View 9 chunks +10 lines, -10 lines 0 comments Download
M src/arm64/cpu-arm64.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/arm64/full-codegen-arm64.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M src/arm64/lithium-arm64.h View 1 2 chunks +4 lines, -2 lines 0 comments Download
M src/arm64/lithium-arm64.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/arm64/macro-assembler-arm64.cc View 1 6 chunks +7 lines, -7 lines 0 comments Download
M src/assembler.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/bootstrapper.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download
M src/code-stubs.h View 1 1 chunk +3 lines, -2 lines 0 comments Download
M src/compiler.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/factory.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/frames.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/full-codegen.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/heap.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/hydrogen.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M src/ia32/assembler-ia32.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/ia32/assembler-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/builtins-ia32.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/code-stubs-ia32.h View 1 2 chunks +4 lines, -2 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 1 2 chunks +3 lines, -2 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 17 chunks +19 lines, -18 lines 0 comments Download
M src/ia32/lithium-ia32.h View 1 5 chunks +14 lines, -6 lines 0 comments Download
M src/ia32/lithium-ia32.cc View 1 5 chunks +8 lines, -6 lines 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M src/ia32/stub-cache-ia32.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M src/ic.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/incremental-marking.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M src/isolate.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M src/lithium-allocator.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/mips/assembler-mips.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/mips/assembler-mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mips/codegen-mips.cc View 1 1 chunk +3 lines, -4 lines 0 comments Download
M src/mips/full-codegen-mips.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M src/mips/lithium-mips.h View 1 3 chunks +6 lines, -2 lines 0 comments Download
M src/mips/lithium-mips.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/objects.cc View 1 2 chunks +3 lines, -2 lines 0 comments Download
M src/objects-visiting-inl.h View 1 2 chunks +4 lines, -4 lines 0 comments Download
M src/platform.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/platform-posix.cc View 1 3 chunks +5 lines, -3 lines 0 comments Download
M src/platform-win32.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/serialize.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/serialize.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/v8.cc View 1 1 chunk +4 lines, -2 lines 0 comments Download
M src/x64/assembler-x64.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/x64/assembler-x64.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/x64/full-codegen-x64.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M src/x64/lithium-x64.h View 1 3 chunks +6 lines, -2 lines 0 comments Download
M src/x64/lithium-x64.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/x64/macro-assembler-x64.cc View 1 7 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Sven Panne
Not exactly a candidate for a beauty contest, but anyway... :-/
6 years, 7 months ago (2014-04-28 12:38:53 UTC) #1
Michael Starzinger
LGTM with comments. https://codereview.chromium.org/260003006/diff/1/src/objects-visiting-inl.h File src/objects-visiting-inl.h (right): https://codereview.chromium.org/260003006/diff/1/src/objects-visiting-inl.h#newcode315 src/objects-visiting-inl.h:315: Serializer::enabled(target->GetIsolate()) || Better use "heap->isolate()" here. ...
6 years, 7 months ago (2014-04-30 09:23:53 UTC) #2
Sven Panne
Feedback addressed, landing. https://codereview.chromium.org/260003006/diff/1/src/objects-visiting-inl.h File src/objects-visiting-inl.h (right): https://codereview.chromium.org/260003006/diff/1/src/objects-visiting-inl.h#newcode315 src/objects-visiting-inl.h:315: Serializer::enabled(target->GetIsolate()) || On 2014/04/30 09:23:53, Michael ...
6 years, 7 months ago (2014-04-30 09:37:19 UTC) #3
Sven Panne
6 years, 7 months ago (2014-04-30 09:51:49 UTC) #4
Message was sent while issue was closed. 
Committed patchset #2 manually as r21083 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698