Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 2599953002: [Offline Pages] Add progress logs for test harness. (Closed)

Created:
4 years ago by romax
Modified:
3 years, 11 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Offline Pages] Add progress logs for test harness. Added some logging in logcat for progress monitoring. BUG=676731 Committed: https://crrev.com/e004367c23e11f306c06620d7a885725267e7693 Cr-Commit-Position: refs/heads/master@{#441175}

Patch Set 1 #

Patch Set 2 : more logs. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -14 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/offlinepages/evaluation/OfflinePageEvaluationBridge.java View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/OfflinePageSavePageLaterEvaluationTest.java View 1 9 chunks +18 lines, -14 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
romax
PTAL, added more logs which can be grep'd in logcat to show progress.
3 years, 11 months ago (2016-12-30 02:06:19 UTC) #2
Pete Williamson
lgtm
3 years, 11 months ago (2017-01-03 18:09:21 UTC) #3
dougarnett
lgtm
3 years, 11 months ago (2017-01-03 18:29:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2599953002/20001
3 years, 11 months ago (2017-01-03 18:32:15 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
3 years, 11 months ago (2017-01-03 19:08:08 UTC) #9
tyrrellfiscuscarrie
3 years, 11 months ago (2017-01-03 19:12:45 UTC) #11
commit-bot: I haz the power
3 years, 11 months ago (2017-01-03 19:14:06 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e004367c23e11f306c06620d7a885725267e7693
Cr-Commit-Position: refs/heads/master@{#441175}

Powered by Google App Engine
This is Rietveld 408576698