Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issue 259993004: Fix and cleanup Map::GeneralizeRepresentation(). (Closed)

Created:
6 years, 8 months ago by Benedikt Meurer
Modified:
6 years, 7 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Visibility:
Public.

Description

Fix and cleanup Map::GeneralizeRepresentation(). TEST=mjsunit/regress/regress-365172-[1-3],mjsunit/field-type-tracking R=svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21006

Patch Set 1 #

Patch Set 2 : Remove TODO. #

Patch Set 3 : Fix root modification case. #

Patch Set 4 : Fix representation check on target map. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+239 lines, -272 lines) Patch
M src/objects.h View 2 chunks +0 lines, -15 lines 0 comments Download
M src/objects.cc View 1 2 3 8 chunks +238 lines, -257 lines 0 comments Download
M src/property.h View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Benedikt Meurer
The mother of all field-type-tracking cleanup CLs... PTAL :-)
6 years, 8 months ago (2014-04-28 08:30:40 UTC) #1
Sven Panne
lgtm
6 years, 7 months ago (2014-04-28 09:51:50 UTC) #2
Benedikt Meurer
6 years, 7 months ago (2014-04-28 10:19:32 UTC) #3
Message was sent while issue was closed.
Committed patchset #4 manually as r21006 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698