Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: src/property.h

Issue 259993004: Fix and cleanup Map::GeneralizeRepresentation(). (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Fix representation check on target map. Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/objects.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_PROPERTY_H_ 5 #ifndef V8_PROPERTY_H_
6 #define V8_PROPERTY_H_ 6 #define V8_PROPERTY_H_
7 7
8 #include "isolate.h" 8 #include "isolate.h"
9 #include "factory.h" 9 #include "factory.h"
10 #include "types.h" 10 #include "types.h"
(...skipping 48 matching lines...) Expand 10 before | Expand all | Expand 10 after
59 Handle<Object> value, 59 Handle<Object> value,
60 PropertyAttributes attributes, 60 PropertyAttributes attributes,
61 PropertyType type, 61 PropertyType type,
62 Representation representation, 62 Representation representation,
63 int field_index = 0) 63 int field_index = 0)
64 : key_(key), 64 : key_(key),
65 value_(value), 65 value_(value),
66 details_(attributes, type, representation, field_index) { } 66 details_(attributes, type, representation, field_index) { }
67 67
68 friend class DescriptorArray; 68 friend class DescriptorArray;
69 friend class Map;
69 }; 70 };
70 71
71 72
72 class FieldDescriptor V8_FINAL : public Descriptor { 73 class FieldDescriptor V8_FINAL : public Descriptor {
73 public: 74 public:
74 FieldDescriptor(Handle<Name> key, 75 FieldDescriptor(Handle<Name> key,
75 int field_index, 76 int field_index,
76 PropertyAttributes attributes, 77 PropertyAttributes attributes,
77 Representation representation) 78 Representation representation)
78 : Descriptor(key, HeapType::Any(key->GetIsolate()), attributes, 79 : Descriptor(key, HeapType::Any(key->GetIsolate()), attributes,
(...skipping 450 matching lines...) Expand 10 before | Expand all | Expand 10 after
529 JSReceiver* holder_; 530 JSReceiver* holder_;
530 Map* transition_; 531 Map* transition_;
531 int number_; 532 int number_;
532 bool cacheable_; 533 bool cacheable_;
533 PropertyDetails details_; 534 PropertyDetails details_;
534 }; 535 };
535 536
536 } } // namespace v8::internal 537 } } // namespace v8::internal
537 538
538 #endif // V8_PROPERTY_H_ 539 #endif // V8_PROPERTY_H_
OLDNEW
« no previous file with comments | « src/objects.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698