Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(411)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 259993003: Make sure gin Handles exist before using them (Closed)

Created:
6 years, 7 months ago by jochen (gone - plz use gerrit)
Modified:
6 years, 7 months ago
Reviewers:
dcarney
CC:
chromium-reviews, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, jam, darin-cc_chromium.org, chromium-apps-reviews_chromium.org, jochen+watch_chromium.org
Visibility:
Public.

Description

Make sure gin Handles exist before using them When we run out of stack space for example, we can't create an handle. BUG=363417 R=dcarney@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266545

Patch Set 1 #

Patch Set 2 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -0 lines) Patch
M chrome/renderer/net/net_error_page_controller.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M content/renderer/dom_automation_controller.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M content/renderer/memory_benchmarking_extension.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M content/renderer/skia_benchmarking_extension.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M content/renderer/stats_collection_controller.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M content/shell/renderer/gc_controller.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M content/shell/renderer/test_runner/accessibility_controller.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M content/shell/renderer/test_runner/event_sender.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M content/shell/renderer/test_runner/gamepad_controller.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M content/shell/renderer/test_runner/test_runner.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M content/shell/renderer/test_runner/text_input_controller.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
jochen (gone - plz use gerrit)
6 years, 7 months ago (2014-04-28 07:43:16 UTC) #1
dcarney
lgtm
6 years, 7 months ago (2014-04-28 07:48:29 UTC) #2
jochen (gone - plz use gerrit)
The CQ bit was checked by jochen@chromium.org
6 years, 7 months ago (2014-04-28 07:48:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/259993003/1
6 years, 7 months ago (2014-04-28 07:49:21 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-28 08:32:36 UTC) #5
commit-bot: I haz the power
Retried try job too often on android_dbg for step(s) slave_steps http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_dbg&number=176347
6 years, 7 months ago (2014-04-28 08:32:37 UTC) #6
jochen (gone - plz use gerrit)
The CQ bit was checked by jochen@chromium.org
6 years, 7 months ago (2014-04-28 09:15:59 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/259993003/20001
6 years, 7 months ago (2014-04-28 09:16:31 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-28 10:08:11 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_rel
6 years, 7 months ago (2014-04-28 10:08:12 UTC) #10
jochen (gone - plz use gerrit)
The CQ bit was checked by jochen@chromium.org
6 years, 7 months ago (2014-04-28 10:17:21 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/259993003/20001
6 years, 7 months ago (2014-04-28 10:18:05 UTC) #12
commit-bot: I haz the power
6 years, 7 months ago (2014-04-28 13:51:02 UTC) #13
Message was sent while issue was closed. 
Change committed as 266545

Powered by Google App Engine
This is Rietveld 408576698