content/shell/renderer/test_runner/gamepad_controller.cc - Issue 259993003: Make sure gin Handles exist before using them

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/renderer/test_runner/gamepad_controller.cc

Issue 259993003: Make sure gin Handles exist before using them (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: updates Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/shell/renderer/test_runner/gamepad_controller.cc

diff --git a/content/shell/renderer/test_runner/gamepad_controller.cc b/content/shell/renderer/test_runner/gamepad_controller.cc

index 6affefb2f7434382206ffdc55d16ed393c6a3e52..f03651be770d09ca922a8d30869b25ad0a2fe931 100644

--- a/content/shell/renderer/test_runner/gamepad_controller.cc

+++ b/content/shell/renderer/test_runner/gamepad_controller.cc

@@ -68,6 +68,8 @@ void GamepadControllerBindings::Install(

gin::Handle<GamepadControllerBindings> bindings =

gin::CreateHandle(isolate, new GamepadControllerBindings(controller));

+ if (bindings.IsEmpty())

+ return;

v8::Handle<v8::Object> global = context->Global();

global->Set(gin::StringToV8(isolate, "gamepadController"), bindings.ToV8());

}