Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 2599923002: Run tools/clang-format-js on chrome/browser/resources/hotword/ (Closed)

Created:
3 years, 12 months ago by Dan Beam
Modified:
3 years, 11 months ago
Reviewers:
kcarattini
CC:
chromium-reviews, rlp+watch_chromium.org, arv+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Run tools/clang-format-js on chrome/browser/resources/hotword/ BUG=567770 R=kcarattini@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation NO_DEPENDENCY_CHECKS=true Committed: https://crrev.com/11ed0b86814fa8394748977cfb81533ca22a4141 Cr-Commit-Position: refs/heads/master@{#441234}

Patch Set 1 #

Patch Set 2 : no dep #

Unified diffs Side-by-side diffs Delta from patch set Stats (+916 lines, -967 lines) Patch
M chrome/browser/resources/hotword/always_on_manager.js View 2 chunks +6 lines, -9 lines 0 comments Download
M chrome/browser/resources/hotword/audio_client.js View 3 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/resources/hotword/base_session_manager.js View 4 chunks +7 lines, -15 lines 0 comments Download
M chrome/browser/resources/hotword/constants.js View 1 chunk +265 lines, -276 lines 0 comments Download
M chrome/browser/resources/hotword/keep_alive.js View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/resources/hotword/launcher_manager.js View 2 chunks +3 lines, -6 lines 0 comments Download
M chrome/browser/resources/hotword/logging.js View 1 chunk +1 line, -4 lines 0 comments Download
M chrome/browser/resources/hotword/metrics.js View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/resources/hotword/nacl_manager.js View 1 chunk +540 lines, -530 lines 0 comments Download
M chrome/browser/resources/hotword/page_audio_manager.js View 9 chunks +27 lines, -55 lines 0 comments Download
M chrome/browser/resources/hotword/state_manager.js View 10 chunks +34 lines, -32 lines 0 comments Download
M chrome/browser/resources/hotword/training_manager.js View 8 chunks +24 lines, -27 lines 0 comments Download

Messages

Total messages: 22 (15 generated)
Dan Beam
General FAQ: How do you create this diff? tools/clang-format-js <dir_name> Did you check it line-by-line? ...
3 years, 12 months ago (2016-12-23 01:42:57 UTC) #4
kcarattini
lgtm
3 years, 11 months ago (2017-01-03 03:49:54 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2599923002/1
3 years, 11 months ago (2017-01-03 19:51:57 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/339987)
3 years, 11 months ago (2017-01-03 21:12:43 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2599923002/20001
3 years, 11 months ago (2017-01-03 21:49:41 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001)
3 years, 11 months ago (2017-01-03 22:56:28 UTC) #20
commit-bot: I haz the power
3 years, 11 months ago (2017-01-03 22:58:53 UTC) #22
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/11ed0b86814fa8394748977cfb81533ca22a4141
Cr-Commit-Position: refs/heads/master@{#441234}

Powered by Google App Engine
This is Rietveld 408576698