Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2599913002:
[MD settings] update protocol handler setting in content settings (Closed)
|
Created:
4 years ago by dschuyler Modified:
3 years, 11 months ago Reviewers:
Dan Beam CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[MD settings] update protocol handler setting in content settings
This CL fixes an issue on the content settings page. The Protocol
Handlers row is updated different from all the other sections in that
list and is not currently updated correctly. This CL fixes the Protocol
Handlers sub-text on that page so that it's correct on first load and
continues to update if changes are made to the enabled state of Protocol
Handlers.
BUG=676527
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Committed: https://crrev.com/40a8332622f24dae5bab19205fde65e8c5c79448
Cr-Commit-Position: refs/heads/master@{#441552}
Patch Set 1 #
Messages
Total messages: 20 (11 generated)
Description was changed from ========== [MD settings] update protocol handler setting in content settings This CL fixes an issue on the content settings page. The Protocol Handlers row is updated different from all the other sections in that list and is not currently updated correctly. This CL fixes the Protocol Handlers sub-text on that page so that it's correct on first load and continues to update if changes are made to the enabled state of Protocol Handlers. BUG=676527 ========== to ========== [MD settings] update protocol handler setting in content settings This CL fixes an issue on the content settings page. The Protocol Handlers row is updated different from all the other sections in that list and is not currently updated correctly. This CL fixes the Protocol Handlers sub-text on that page so that it's correct on first load and continues to update if changes are made to the enabled state of Protocol Handlers. BUG=676527 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
dschuyler@chromium.org changed reviewers: + tommycli@chromium.org
dschuyler@chromium.org changed reviewers: + dbeam@chromium.org - tommycli@chromium.org
Tommy is OOO, switching to dbeam@ for review.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
On 2016/12/23 01:04:31, dschuyler wrote: > Tommy is OOO, switching to dbeam@ for review. friendly ping.
it would be nice to combine code between updateHandlersEnabled_ and updateDefaultValueLabel_ but i'll understand if it's not really that much gained lgtm
if you could add a test that'd be cool, too, though... that invokes the webui listener and detects changes
On 2017/01/04 01:20:17, Dan Beam wrote: > it would be nice to combine code between updateHandlersEnabled_ and > updateDefaultValueLabel_ but i'll understand if it's not really that much gained > > lgtm I think that's reasonable. I look at that and the unit test for a follow-up CL.
The CQ bit was checked by dschuyler@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1483575262421760, "parent_rev":
"49f169481c12cceca8b2888eb041da953995ca46", "commit_rev":
"5285d6fd7d634d9f3d772fbdd83c55af6efdfbf1"}
Message was sent while issue was closed.
Description was changed from ========== [MD settings] update protocol handler setting in content settings This CL fixes an issue on the content settings page. The Protocol Handlers row is updated different from all the other sections in that list and is not currently updated correctly. This CL fixes the Protocol Handlers sub-text on that page so that it's correct on first load and continues to update if changes are made to the enabled state of Protocol Handlers. BUG=676527 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== [MD settings] update protocol handler setting in content settings This CL fixes an issue on the content settings page. The Protocol Handlers row is updated different from all the other sections in that list and is not currently updated correctly. This CL fixes the Protocol Handlers sub-text on that page so that it's correct on first load and continues to update if changes are made to the enabled state of Protocol Handlers. BUG=676527 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2599913002 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== [MD settings] update protocol handler setting in content settings This CL fixes an issue on the content settings page. The Protocol Handlers row is updated different from all the other sections in that list and is not currently updated correctly. This CL fixes the Protocol Handlers sub-text on that page so that it's correct on first load and continues to update if changes are made to the enabled state of Protocol Handlers. BUG=676527 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2599913002 ========== to ========== [MD settings] update protocol handler setting in content settings This CL fixes an issue on the content settings page. The Protocol Handlers row is updated different from all the other sections in that list and is not currently updated correctly. This CL fixes the Protocol Handlers sub-text on that page so that it's correct on first load and continues to update if changes are made to the enabled state of Protocol Handlers. BUG=676527 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/40a8332622f24dae5bab19205fde65e8c5c79448 Cr-Commit-Position: refs/heads/master@{#441552} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/40a8332622f24dae5bab19205fde65e8c5c79448 Cr-Commit-Position: refs/heads/master@{#441552} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
