Reland "Optimize KURL protocols"

Reland "Optimize KURL protocols"

This reverts commit 8885747f52b034575336f97e354fa8043f6c1b9f, which
reverted 775abc2d7c903f191f7b24f8b299ebabbea3f624 (reviewed at
https://codereview.chromium.org/2463703002/)

The change was triggering a bad DCHECK in ~StringView, which
has been amended in the dependent CL.

BUG=348655, 674388
Committed: https://crrev.com/6a44155f151b212fa9f99acd9226505ec42e78ab
Cr-Commit-Position: refs/heads/master@{#441588}

[Charlie Harrison, 2016-12-22 18:29:39]

The CQ bit was checked by csharrison@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-22 18:29:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Charlie Harrison, 2016-12-22 18:39:54]

Description was changed from

==========
Reland "Optimize KURL protocols"

This reverts commit 8885747f52b034575336f97e354fa8043f6c1b9f, which
reverted 775abc2d7c903f191f7b24f8b299ebabbea3f624 (reviewed at
https://codereview.chromium.org/2463703002/)

The code is a code-for-code reland except for one change in StringView,
altering a bad DCHECK.

BUG=348655,674388
==========

to

==========
Reland "Optimize KURL protocols"

This reverts commit 8885747f52b034575336f97e354fa8043f6c1b9f, which
reverted 775abc2d7c903f191f7b24f8b299ebabbea3f624 (reviewed at
https://codereview.chromium.org/2463703002/)


BUG=348655,674388
==========

[Charlie Harrison, 2016-12-22 18:56:48]

Description was changed from

==========
Reland "Optimize KURL protocols"

This reverts commit 8885747f52b034575336f97e354fa8043f6c1b9f, which
reverted 775abc2d7c903f191f7b24f8b299ebabbea3f624 (reviewed at
https://codereview.chromium.org/2463703002/)


BUG=348655,674388
==========

to

==========
Reland "Optimize KURL protocols"

This reverts commit 8885747f52b034575336f97e354fa8043f6c1b9f, which
reverted 775abc2d7c903f191f7b24f8b299ebabbea3f624 (reviewed at
https://codereview.chromium.org/2463703002/)

The change was triggering a bad DCHECK in ~StringView, which
has been amended here.

BUG=348655,674388
==========

[Charlie Harrison, 2016-12-22 18:57:58]

csharrison@chromium.org changed reviewers:
+ esprehn@chromium.org

[Charlie Harrison, 2016-12-22 18:57:59]

esprehn: ptal. This is a reland with two fixes:
1. The DCHECK change as discussed in the crbug.
2. Changed AtomicString(protocol.toString()) to protocol.toAtomicString(), as
you caught in the crbug.

[esprehn, 2016-12-22 20:13:52]

Can we fix StringView in its own parch first?

[commit-bot: I haz the power, 2016-12-22 20:19:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-22 20:19:42]

Dry run: This issue passed the CQ dry run.

[Charlie Harrison, 2016-12-22 20:21:14]

On 2016/12/22 20:13:52, esprehn wrote:
> Can we fix StringView in its own parch first?

Done.

[Charlie Harrison, 2016-12-22 20:26:37]

Description was changed from

==========
Reland "Optimize KURL protocols"

This reverts commit 8885747f52b034575336f97e354fa8043f6c1b9f, which
reverted 775abc2d7c903f191f7b24f8b299ebabbea3f624 (reviewed at
https://codereview.chromium.org/2463703002/)

The change was triggering a bad DCHECK in ~StringView, which
has been amended here.

BUG=348655,674388
==========

to

==========
Reland "Optimize KURL protocols"

This reverts commit 8885747f52b034575336f97e354fa8043f6c1b9f, which
reverted 775abc2d7c903f191f7b24f8b299ebabbea3f624 (reviewed at
https://codereview.chromium.org/2463703002/)

The change was triggering a bad DCHECK in ~StringView, which
has been amended in the dependent CL.

BUG=348655,674388
==========

[Charlie Harrison, 2017-01-03 14:08:11]

The CQ bit was checked by csharrison@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-03 14:08:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Charlie Harrison, 2017-01-03 14:09:19]

esprehn: friendly ping for this (now) simple reland.

[commit-bot: I haz the power, 2017-01-03 15:53:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-03 15:53:22]

Dry run: This issue passed the CQ dry run.

[esprehn, 2017-01-05 01:30:36]

lgtm, I usually just post the original patch though instead of the revert of a
revert etc. since I think it's nicer in the commit log.

[Charlie Harrison, 2017-01-05 03:11:19]

On 2017/01/05 01:30:36, esprehn wrote:
> lgtm, I usually just post the original patch though instead of the revert of a
> revert etc. since I think it's nicer in the commit log.

Good point. Will do that next time.

[Charlie Harrison, 2017-01-05 03:11:26]

The CQ bit was checked by csharrison@chromium.org

[commit-bot: I haz the power, 2017-01-05 03:11:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-05 05:04:36]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1483585886161010,
"parent_rev": "d6f76ad550e939501c205708567d0283cf2a863e", "commit_rev":
"084849135d8ba4b647332f2cb3074f93e53d1800"}

[commit-bot: I haz the power, 2017-01-05 05:05:10]

Description was changed from

==========
Reland "Optimize KURL protocols"

This reverts commit 8885747f52b034575336f97e354fa8043f6c1b9f, which
reverted 775abc2d7c903f191f7b24f8b299ebabbea3f624 (reviewed at
https://codereview.chromium.org/2463703002/)

The change was triggering a bad DCHECK in ~StringView, which
has been amended in the dependent CL.

BUG=348655,674388
==========

to

==========
Reland "Optimize KURL protocols"

This reverts commit 8885747f52b034575336f97e354fa8043f6c1b9f, which
reverted 775abc2d7c903f191f7b24f8b299ebabbea3f624 (reviewed at
https://codereview.chromium.org/2463703002/)

The change was triggering a bad DCHECK in ~StringView, which
has been amended in the dependent CL.

BUG=348655,674388

Review-Url: https://codereview.chromium.org/2599853002
==========

[commit-bot: I haz the power, 2017-01-05 05:05:14]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2017-01-05 05:11:01]

Description was changed from

==========
Reland "Optimize KURL protocols"

This reverts commit 8885747f52b034575336f97e354fa8043f6c1b9f, which
reverted 775abc2d7c903f191f7b24f8b299ebabbea3f624 (reviewed at
https://codereview.chromium.org/2463703002/)

The change was triggering a bad DCHECK in ~StringView, which
has been amended in the dependent CL.

BUG=348655,674388

Review-Url: https://codereview.chromium.org/2599853002
==========

to

==========
Reland "Optimize KURL protocols"

This reverts commit 8885747f52b034575336f97e354fa8043f6c1b9f, which
reverted 775abc2d7c903f191f7b24f8b299ebabbea3f624 (reviewed at
https://codereview.chromium.org/2463703002/)

The change was triggering a bad DCHECK in ~StringView, which
has been amended in the dependent CL.

BUG=348655,674388

Committed: https://crrev.com/6a44155f151b212fa9f99acd9226505ec42e78ab
Cr-Commit-Position: refs/heads/master@{#441588}
==========

[commit-bot: I haz the power, 2017-01-05 05:11:02]

Patchset 3 (id:??) landed as
https://crrev.com/6a44155f151b212fa9f99acd9226505ec42e78ab
Cr-Commit-Position: refs/heads/master@{#441588}