|
|
Created:
6 years, 7 months ago by Xianzhu Modified:
6 years, 7 months ago CC:
chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Visibility:
Public. |
DescriptionRemove ui_unittests -> packed_resources dependency
The dependency is no longer required.
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266782
Patch Set 1 #
Messages
Total messages: 15 (0 generated)
Did you check in a clobber build, android_builder_tests still works?
On 2014/04/28 18:23:40, tfarina wrote: > Did you check in a clobber build, android_builder_tests still works? Tried locally. The build succeeded. Several test cases failed or crashed when running ui_unittests, but the they also failed or crashed without this change.
On 2014/04/28 18:55:52, Xianzhu wrote: > On 2014/04/28 18:23:40, tfarina wrote: > > Did you check in a clobber build, android_builder_tests still works? > > Tried locally. The build succeeded. Several test cases failed or crashed when > running ui_unittests, but the they also failed or crashed without this change. Could you file a bug?
On 2014/04/28 20:07:11, tfarina wrote: > On 2014/04/28 18:55:52, Xianzhu wrote: > > On 2014/04/28 18:23:40, tfarina wrote: > > > Did you check in a clobber build, android_builder_tests still works? > > > > Tried locally. The build succeeded. Several test cases failed or crashed when > > running ui_unittests, but the they also failed or crashed without this change. > > Could you file a bug? Didn't file a bug because the test passes on bots. I guess there is some local configuration problem is causing the failures, but I haven't got time to investigate it.
On 2014/04/28 20:14:35, Xianzhu wrote: > On 2014/04/28 20:07:11, tfarina wrote: > > On 2014/04/28 18:55:52, Xianzhu wrote: > > > On 2014/04/28 18:23:40, tfarina wrote: > > > > Did you check in a clobber build, android_builder_tests still works? > > > > > > Tried locally. The build succeeded. Several test cases failed or crashed > when > > > running ui_unittests, but the they also failed or crashed without this > change. > > > > Could you file a bug? > > Didn't file a bug because the test passes on bots. I guess there is some local > configuration problem is causing the failures, but I haven't got time to > investigate it. Run ui_unittests after content_unittests, and it succeeded. The failure is related to ICU data file. Will fix that. It is not related to this change.
On 2014/04/28 20:44:57, Xianzhu wrote: > On 2014/04/28 20:14:35, Xianzhu wrote: > > On 2014/04/28 20:07:11, tfarina wrote: > > > On 2014/04/28 18:55:52, Xianzhu wrote: > > > > On 2014/04/28 18:23:40, tfarina wrote: > > > > > Did you check in a clobber build, android_builder_tests still works? > > > > > > > > Tried locally. The build succeeded. Several test cases failed or crashed > > when > > > > running ui_unittests, but the they also failed or crashed without this > > change. > > > > > > Could you file a bug? > > > > Didn't file a bug because the test passes on bots. I guess there is some local > > configuration problem is causing the failures, but I haven't got time to > > investigate it. > > Run ui_unittests after content_unittests, and it succeeded. The failure is > related to ICU data file. Will fix that. It is not related to this change. Is the icu issue related to crbug.com/351052? lgtm for what we have here, providing you have tried this locally and bots are green. You can put this on CQ with my approval, since build/OWNERS has *.
On 2014/04/28 22:18:22, tfarina wrote: > On 2014/04/28 20:44:57, Xianzhu wrote: > > On 2014/04/28 20:14:35, Xianzhu wrote: > > > On 2014/04/28 20:07:11, tfarina wrote: > > > > On 2014/04/28 18:55:52, Xianzhu wrote: > > > > > On 2014/04/28 18:23:40, tfarina wrote: > > > > > > Did you check in a clobber build, android_builder_tests still works? > > > > > > > > > > Tried locally. The build succeeded. Several test cases failed or crashed > > > when > > > > > running ui_unittests, but the they also failed or crashed without this > > > change. > > > > > > > > Could you file a bug? > > > > > > Didn't file a bug because the test passes on bots. I guess there is some > local > > > configuration problem is causing the failures, but I haven't got time to > > > investigate it. > > > > Run ui_unittests after content_unittests, and it succeeded. The failure is > > related to ICU data file. Will fix that. It is not related to this change. > > Is the icu issue related to crbug.com/351052? > No. My encountered issue will be fixed by https://codereview.chromium.org/259123002/. > lgtm for what we have here, providing you have tried this locally and bots are > green. > > You can put this on CQ with my approval, since build/OWNERS has *.
The CQ bit was checked by wangxianzhu@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wangxianzhu@chromium.org/259983007/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: tryserver.chromium on linux_chromium_clang_dbg
The CQ bit was checked by wangxianzhu@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wangxianzhu@chromium.org/259983007/1
Message was sent while issue was closed.
Change committed as 266782 |