Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 259983007: Remove ui_unittests -> packed_resources dependency (Closed)

Created:
6 years, 7 months ago by Xianzhu
Modified:
6 years, 7 months ago
Reviewers:
tfarina, tapted
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Remove ui_unittests -> packed_resources dependency The dependency is no longer required. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266782

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M build/all.gyp View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
Xianzhu
6 years, 7 months ago (2014-04-28 17:46:51 UTC) #1
tfarina
Did you check in a clobber build, android_builder_tests still works?
6 years, 7 months ago (2014-04-28 18:23:40 UTC) #2
Xianzhu
On 2014/04/28 18:23:40, tfarina wrote: > Did you check in a clobber build, android_builder_tests still ...
6 years, 7 months ago (2014-04-28 18:55:52 UTC) #3
tfarina
On 2014/04/28 18:55:52, Xianzhu wrote: > On 2014/04/28 18:23:40, tfarina wrote: > > Did you ...
6 years, 7 months ago (2014-04-28 20:07:11 UTC) #4
Xianzhu
On 2014/04/28 20:07:11, tfarina wrote: > On 2014/04/28 18:55:52, Xianzhu wrote: > > On 2014/04/28 ...
6 years, 7 months ago (2014-04-28 20:14:35 UTC) #5
Xianzhu
On 2014/04/28 20:14:35, Xianzhu wrote: > On 2014/04/28 20:07:11, tfarina wrote: > > On 2014/04/28 ...
6 years, 7 months ago (2014-04-28 20:44:57 UTC) #6
tfarina
On 2014/04/28 20:44:57, Xianzhu wrote: > On 2014/04/28 20:14:35, Xianzhu wrote: > > On 2014/04/28 ...
6 years, 7 months ago (2014-04-28 22:18:22 UTC) #7
Xianzhu
On 2014/04/28 22:18:22, tfarina wrote: > On 2014/04/28 20:44:57, Xianzhu wrote: > > On 2014/04/28 ...
6 years, 7 months ago (2014-04-28 22:23:45 UTC) #8
Xianzhu
The CQ bit was checked by wangxianzhu@chromium.org
6 years, 7 months ago (2014-04-28 22:23:51 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wangxianzhu@chromium.org/259983007/1
6 years, 7 months ago (2014-04-28 22:25:59 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-28 22:28:42 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_clang_dbg
6 years, 7 months ago (2014-04-28 22:28:42 UTC) #12
Xianzhu
The CQ bit was checked by wangxianzhu@chromium.org
6 years, 7 months ago (2014-04-28 22:52:33 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wangxianzhu@chromium.org/259983007/1
6 years, 7 months ago (2014-04-28 22:53:41 UTC) #14
commit-bot: I haz the power
6 years, 7 months ago (2014-04-29 07:58:24 UTC) #15
Message was sent while issue was closed.
Change committed as 266782

Powered by Google App Engine
This is Rietveld 408576698