Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(789)

Unified Diff: build/all.gyp

Issue 259983007: Remove ui_unittests -> packed_resources dependency (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/all.gyp
diff --git a/build/all.gyp b/build/all.gyp
index c4c1ce1d4bb36ea0f19cf48e48ac93a54098a74b..e0749d4f8fe15a80b778b9469803c99a25678138 100644
--- a/build/all.gyp
+++ b/build/all.gyp
@@ -742,11 +742,6 @@
'../tools/android/findbugs_plugin/findbugs_plugin.gyp:findbugs_plugin_test',
'../ui/events/events.gyp:events_unittests',
'../ui/ui_unittests.gyp:ui_unittests',
- # Required by ui_unittests.
- # TODO(wangxianzhu): It'd better let ui_unittests depend on it, but
- # this would cause circular gyp dependency which needs refactoring the
- # gyps to resolve.
- '../chrome/chrome_resources.gyp:packed_resources',
],
'conditions': [
['"<(gtest_target_type)"=="shared_library"', {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698