Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issue 2599813002: Use double for time-related variables (Closed)

Created:
4 years ago by Raymond Toy
Modified:
4 years ago
Reviewers:
hongchan
CC:
chromium-reviews, blink-reviews, haraken, Raymond Toy, hongchan
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use double for time-related variables This doesn't convert all time-related variables from float to double, which requires a more careful examination. (One such change changes the test results.) Only enough to fix the bug. BUG=675080 TEST=None. Not testable in a layout test in a reasonable number of frames Committed: https://crrev.com/b5abf978ca7c77453c1932080bb5a823a48465ab Cr-Commit-Position: refs/heads/master@{#440493}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/modules/webaudio/AudioParamTimeline.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (8 generated)
Raymond Toy
4 years ago (2016-12-22 17:48:13 UTC) #3
hongchan
lgtm
4 years ago (2016-12-22 17:49:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2599813002/1
4 years ago (2016-12-22 17:55:52 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/204151)
4 years ago (2016-12-22 19:15:59 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2599813002/1
4 years ago (2016-12-22 20:12:17 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-22 20:48:30 UTC) #13
commit-bot: I haz the power
4 years ago (2016-12-22 20:51:04 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b5abf978ca7c77453c1932080bb5a823a48465ab
Cr-Commit-Position: refs/heads/master@{#440493}

Powered by Google App Engine
This is Rietveld 408576698