Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Issue 2599773002: headless: Improve documentation (Closed)

Created:
4 years ago by Sami
Modified:
3 years, 12 months ago
Reviewers:
Eric Seckler
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

headless: Improve documentation BUG=546953 Committed: https://crrev.com/4c9d164c03c2da9d7051d859a07e6febdfcd9354 Cr-Commit-Position: refs/heads/master@{#440617}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -13 lines) Patch
M headless/README.md View 1 5 chunks +36 lines, -13 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
Sami
4 years ago (2016-12-22 12:06:10 UTC) #3
Eric Seckler
lgtm! https://codereview.chromium.org/2599773002/diff/1/headless/README.md File headless/README.md (right): https://codereview.chromium.org/2599773002/diff/1/headless/README.md#newcode16 headless/README.md:16: $ chrome --headless --remote-debugging-port=9222 https://chromium.org should we mention ...
3 years, 12 months ago (2016-12-23 10:51:46 UTC) #4
Sami
Thanks! https://codereview.chromium.org/2599773002/diff/1/headless/README.md File headless/README.md (right): https://codereview.chromium.org/2599773002/diff/1/headless/README.md#newcode16 headless/README.md:16: $ chrome --headless --remote-debugging-port=9222 https://chromium.org On 2016/12/23 10:51:46, ...
3 years, 12 months ago (2016-12-23 10:59:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2599773002/20001
3 years, 12 months ago (2016-12-23 11:00:21 UTC) #8
Eric Seckler
still lgtm :)
3 years, 12 months ago (2016-12-23 11:00:39 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
3 years, 12 months ago (2016-12-23 11:16:25 UTC) #12
commit-bot: I haz the power
3 years, 12 months ago (2016-12-23 11:19:11 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4c9d164c03c2da9d7051d859a07e6febdfcd9354
Cr-Commit-Position: refs/heads/master@{#440617}

Powered by Google App Engine
This is Rietveld 408576698