Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(443)

Issue 2599703002: gpu: Add mojom for GpuPreferences. (Closed)

Created:
4 years ago by sadrul
Modified:
4 years ago
Reviewers:
Tom Sepez, kenrb
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, piman+watch_chromium.org, darin (slow to review)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

gpu: Add mojom for GpuPreferences. BUG=643746 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/c37fd9a74b45e4ae11752e712dc9133b1001d335 Cr-Commit-Position: refs/heads/master@{#440538}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : fix win #

Unified diffs Side-by-side diffs Delta from patch set Stats (+342 lines, -0 lines) Patch
M gpu/ipc/common/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A gpu/ipc/common/gpu_preferences.mojom View 1 2 1 chunk +53 lines, -0 lines 0 comments Download
A gpu/ipc/common/gpu_preferences.typemap View 1 2 1 chunk +16 lines, -0 lines 0 comments Download
A gpu/ipc/common/gpu_preferences_struct_traits.h View 1 2 1 chunk +238 lines, -0 lines 0 comments Download
M gpu/ipc/common/struct_traits_unittest.cc View 1 2 3 2 chunks +29 lines, -0 lines 0 comments Download
M gpu/ipc/common/traits_test_service.mojom View 1 2 2 chunks +4 lines, -0 lines 0 comments Download
M gpu/ipc/common/typemaps.gni View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 30 (24 generated)
sadrul
4 years ago (2016-12-22 18:03:49 UTC) #12
sadrul
+kenrb@ since Tom is ooo
4 years ago (2016-12-22 18:04:29 UTC) #15
kenrb
lgtm
4 years ago (2016-12-22 20:26:05 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2599703002/60001
4 years ago (2016-12-22 23:20:49 UTC) #25
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years ago (2016-12-22 23:26:44 UTC) #28
commit-bot: I haz the power
4 years ago (2016-12-22 23:28:34 UTC) #30
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/c37fd9a74b45e4ae11752e712dc9133b1001d335
Cr-Commit-Position: refs/heads/master@{#440538}

Powered by Google App Engine
This is Rietveld 408576698