Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 2599693002: Fix DoubleToRadixCString wrt Number.MIN_VALUE. (Closed)

Created:
4 years ago by Yang
Modified:
4 years ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix DoubleToRadixCString wrt Number.MIN_VALUE. R=bmeurer@chromium.org BUG=v8:5767 Review-Url: https://codereview.chromium.org/2599693002 Cr-Commit-Position: refs/heads/master@{#41910} Committed: https://chromium.googlesource.com/v8/v8/+/546152e754cade5898c48fc05535475014ce5dfd

Patch Set 1 #

Patch Set 2 : Fix DoubleToRadixCString wrt Number.MIN_VALUE. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M src/conversions.cc View 1 2 chunks +4 lines, -0 lines 0 comments Download
A test/mjsunit/regress/regress-5767.js View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
Yang
4 years ago (2016-12-22 06:25:53 UTC) #1
Benedikt Meurer
lgtm
4 years ago (2016-12-22 06:27:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2599693002/20001
4 years ago (2016-12-22 06:32:49 UTC) #7
commit-bot: I haz the power
4 years ago (2016-12-22 06:57:07 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/546152e754cade5898c48fc05535475014c...

Powered by Google App Engine
This is Rietveld 408576698