DevTools: Show not found message in FilteredListWidgets

DevTools: Show not found message in FilteredListWidgets

This also lets the FilteredListWidget be smaller if it has few results.

BUG=662081
Review-Url: https://codereview.chromium.org/2599623002
Cr-Commit-Position: refs/heads/master@{#443170}
Committed: https://chromium.googlesource.com/chromium/src/+/cf75b7400451e8457d5b9489e27158173727ea09

[einbinder, 2016-12-22 00:51:55]

Description was changed from

==========
Merge branch 'master' into not_found


partial

BUG=
==========

to

==========
DevTools: Show not found message in FilteredListWidgets

BUG=662081
==========

[einbinder, 2016-12-22 00:51:56]

einbinder@chromium.org changed reviewers:
+ dgozman@chromium.org

[einbinder, 2016-12-22 00:54:31]

http://i.imgur.com/vs4ssnG.png

http://i.imgur.com/nLKkteZ.png

http://i.imgur.com/6WXFzmT.png

ptal

[einbinder, 2016-12-22 00:54:59]

Description was changed from

==========
DevTools: Show not found message in FilteredListWidgets

BUG=662081
==========

to

==========
DevTools: Show not found message in FilteredListWidgets

This also lets the FilteredListWidget be smaller if it has few results.

BUG=662081
==========

[dgozman, 2016-12-27 19:36:48]

Let's beautify the message :-)

https://codereview.chromium.org/2599623002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/ui/Dialog.js (right):

https://codereview.chromium.org/2599623002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/ui/Dialog.js:49: this._fixedHeight
= true;
Let's instead position based on maxHeight (if present) in wrapsContent mode.

[dgozman, 2016-12-27 19:37:33]

Let's also use different not found text.

[einbinder, 2017-01-09 23:19:17]

http://i.imgur.com/mEoVAqO.png

http://i.imgur.com/uI4T1J1.png

http://i.imgur.com/pwNNrxF.png

https://codereview.chromium.org/2599623002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/ui/Dialog.js (right):

https://codereview.chromium.org/2599623002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/ui/Dialog.js:49: this._fixedHeight
= true;
On 2016/12/27 at 19:36:48, dgozman wrote:
> Let's instead position based on maxHeight (if present) in wrapsContent mode.

Done.

[dgozman, 2017-01-10 00:21:34]

lgtm

https://codereview.chromium.org/2599623002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/ui_lazy/FilteredListWidget.js
(left):

https://codereview.chromium.org/2599623002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/ui_lazy/FilteredListWidget.js:107:
if (!this._delegate.itemCount())
Please restore.

https://codereview.chromium.org/2599623002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/ui_lazy/FilteredListWidget.js
(right):

https://codereview.chromium.org/2599623002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/ui_lazy/FilteredListWidget.js:304:
var beforeDialogHeight = this._dialog.element.style.height;
Let's have comments explaining that we rely on css to set the proper list height
(based on max-height) and so on....

https://codereview.chromium.org/2599623002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/ui_lazy/filteredListWidget.css
(right):

https://codereview.chromium.org/2599623002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/ui_lazy/filteredListWidget.css:116:
height:34px;
style: space after colon

[einbinder, 2017-01-10 01:38:34]

https://codereview.chromium.org/2599623002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/ui_lazy/FilteredListWidget.js
(left):

https://codereview.chromium.org/2599623002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/ui_lazy/FilteredListWidget.js:107:
if (!this._delegate.itemCount())
On 2017/01/10 at 00:21:34, dgozman wrote:
> Please restore.

Done.

https://codereview.chromium.org/2599623002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/ui_lazy/FilteredListWidget.js
(right):

https://codereview.chromium.org/2599623002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/ui_lazy/FilteredListWidget.js:304:
var beforeDialogHeight = this._dialog.element.style.height;
On 2017/01/10 at 00:21:34, dgozman wrote:
> Let's have comments explaining that we rely on css to set the proper list
height (based on max-height) and so on....

Done.

https://codereview.chromium.org/2599623002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/ui_lazy/filteredListWidget.css
(right):

https://codereview.chromium.org/2599623002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/ui_lazy/filteredListWidget.css:116:
height:34px;
On 2017/01/10 at 00:21:34, dgozman wrote:
> style: space after colon

Done.

[einbinder, 2017-01-10 01:38:42]

The CQ bit was checked by einbinder@chromium.org

[einbinder, 2017-01-10 01:38:42]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2599623002/#ps40001
(title: "comments")

[commit-bot: I haz the power, 2017-01-10 01:39:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-10 03:42:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-10 03:42:15]

Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)

[einbinder, 2017-01-10 21:24:17]

The CQ bit was checked by einbinder@chromium.org

[commit-bot: I haz the power, 2017-01-10 21:24:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-10 21:31:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-10 21:31:03]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[einbinder, 2017-01-11 00:28:57]

The CQ bit was checked by einbinder@chromium.org

[einbinder, 2017-01-11 00:28:57]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2599623002/#ps60001
(title: "merge")

[commit-bot: I haz the power, 2017-01-11 00:29:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 02:01:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-11 02:01:49]

Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[einbinder, 2017-01-11 02:31:59]

The CQ bit was checked by einbinder@chromium.org

[commit-bot: I haz the power, 2017-01-11 02:33:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 04:09:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-11 04:09:06]

Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[einbinder, 2017-01-12 03:12:09]

The CQ bit was checked by einbinder@chromium.org

[commit-bot: I haz the power, 2017-01-12 03:12:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-12 03:20:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-12 03:20:47]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[einbinder, 2017-01-12 04:35:22]

The CQ bit was checked by einbinder@chromium.org

[commit-bot: I haz the power, 2017-01-12 04:35:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-12 06:43:26]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1484195722133850,
"parent_rev": "e0959faf15de830455fa90014920adec9c880bc2", "commit_rev":
"cf75b7400451e8457d5b9489e27158173727ea09"}

[commit-bot: I haz the power, 2017-01-12 06:44:23]

Description was changed from

==========
DevTools: Show not found message in FilteredListWidgets

This also lets the FilteredListWidget be smaller if it has few results.

BUG=662081
==========

to

==========
DevTools: Show not found message in FilteredListWidgets

This also lets the FilteredListWidget be smaller if it has few results.

BUG=662081

Review-Url: https://codereview.chromium.org/2599623002
Cr-Commit-Position: refs/heads/master@{#443170}
Committed:
https://chromium.googlesource.com/chromium/src/+/cf75b7400451e8457d5b9489e271...
==========

[commit-bot: I haz the power, 2017-01-12 06:44:24]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/cf75b7400451e8457d5b9489e271...