Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(568)

Issue 2599593003: Touch up md_history presubmit (Closed)

Created:
4 years ago by Dan Beam
Modified:
3 years, 11 months ago
Reviewers:
calamity
CC:
chromium-reviews, Patrick Dubroy, michaelpg+watch-md-ui_chromium.org, dbeam+watch-history_chromium.org, pam+watch_chromium.org, arv+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Touch up md_history presubmit - os.path is provided by input_api, and it's preferred to use it - time does not seem to be used any more - input_api.change.AffectedFiles() with a "starts with my dir" filter is equivalent to input_api.AffectedFiles(); also, harness file_filter= - os.path.split()[1] is equivalent to os.path.basename(), which is more readable, IMO R=calamity@chromium.org BUG=none CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/753815c5ad1297a9b8b535baa2bf05884a706313 Cr-Commit-Position: refs/heads/master@{#440937}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -14 lines) Patch
M chrome/browser/resources/md_history/PRESUBMIT.py View 1 chunk +13 lines, -14 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
Dan Beam
4 years ago (2016-12-22 05:30:25 UTC) #3
calamity
lgtm
3 years, 11 months ago (2016-12-29 00:26:27 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2599593003/1
3 years, 11 months ago (2016-12-29 04:37:49 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 11 months ago (2016-12-29 05:08:52 UTC) #13
commit-bot: I haz the power
3 years, 11 months ago (2017-01-02 15:51:44 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/753815c5ad1297a9b8b535baa2bf05884a706313
Cr-Commit-Position: refs/heads/master@{#440937}

Powered by Google App Engine
This is Rietveld 408576698