Convert AudioBufferSource start and loop-comprehensive tests to testharness

Convert AudioBufferSource start and loop-comprehensive tests to testharness

Manually convert test to use testharness

BUG=676394
TEST=audiobuffersource-start.html, audiobuffersource-loop-comprehensive.html

Review-Url: https://codereview.chromium.org/2599573003
Cr-Commit-Position: refs/heads/master@{#445224}
Committed: https://chromium.googlesource.com/chromium/src/+/3ae4ce708f660411f8a26da7a4382c6842c75346

[Raymond Toy, 2017-01-05 20:48:59]

Description was changed from

==========
Convert AudioBufferSource tests to testharness

Manually convert test to use testharness

BUG=676394
TEST=audiobuffersource-start.html, audiobuffersource-loop-comprehensive.html
==========

to

==========
Convert AudioBufferSource start and loop-comprehensive tests to testharness

Manually convert test to use testharness

BUG=676394
TEST=audiobuffersource-start.html, audiobuffersource-loop-comprehensive.html
==========

[Raymond Toy, 2017-01-13 19:02:50]

rtoy@chromium.org changed reviewers:
+ hongchan@chromium.org

[Raymond Toy, 2017-01-13 19:02:51]

PTAL.

The output is kind of ugly, but I didn't want to rethink better messaging, and
it kind of preserves the old output.

[Raymond Toy, 2017-01-13 19:03:35]

Output for start.html:

This is a testharness.js-based test.
PASS # AUDIT TASK RUNNER STARTED. 
PASS   Case 0: start(when): implicitly play whole buffer from beginning to end
is identical to the array [0,1,2,3,4,5,6,7,0,0,0,0,0,0,0,0...]. 
PASS   Case 0: start(when): implicitly play whole buffer from beginning to end:
tail contains only the constant 0. 
PASS   Case 1: start(when, 0): play whole buffer from beginning to end
explicitly giving offset of 0 is identical to the array
[0,1,2,3,4,5,6,7,0,0,0,0,0,0,0,0...]. 
PASS   Case 1: start(when, 0): play whole buffer from beginning to end
explicitly giving offset of 0: tail contains only the constant 0. 
PASS   Case 2: start(when, 0, 8_frames): play whole buffer from beginning to end
explicitly giving offset of 0 and duration of 8 frames is identical to the array
[0,1,2,3,4,5,6,7,0,0,0,0,0,0,0,0...]. 
PASS   Case 2: start(when, 0, 8_frames): play whole buffer from beginning to end
explicitly giving offset of 0 and duration of 8 frames: tail contains only the
constant 0. 
PASS   Case 3: start(when, 4_frames): play with explicit non-zero offset is
identical to the array [4,5,6,7,0,0,0,0,0,0,0,0,0,0,0,0...]. 
PASS   Case 3: start(when, 4_frames): play with explicit non-zero offset: tail
contains only the constant 0. 
PASS   Case 4: start(when, 4_frames, 4_frames): play with explicit non-zero
offset and duration is identical to the array
[4,5,6,7,0,0,0,0,0,0,0,0,0,0,0,0...]. 
PASS   Case 4: start(when, 4_frames, 4_frames): play with explicit non-zero
offset and duration: tail contains only the constant 0. 
PASS   Case 5: start(when, 7_frames): play with explicit non-zero offset near
end of buffer is identical to the array [7,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0...]. 
PASS   Case 5: start(when, 7_frames): play with explicit non-zero offset near
end of buffer: tail contains only the constant 0. 
PASS   Case 6: start(when, 8_frames): play with explicit offset at end of buffer
is identical to the array [0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0...]. 
PASS   Case 6: start(when, 8_frames): play with explicit offset at end of
buffer: tail contains only the constant 0. 
PASS   Case 7: start(when, 9_frames): play with explicit offset past end of
buffer is identical to the array [0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0...]. 
PASS   Case 7: start(when, 9_frames): play with explicit offset past end of
buffer: tail contains only the constant 0. 
PASS   Case 8: start(when, 0, 15_frames): play with whole buffer, with long
duration (clipped) is identical to the array
[0,1,2,3,4,5,6,7,0,0,0,0,0,0,0,0...]. 
PASS   Case 8: start(when, 0, 15_frames): play with whole buffer, with long
duration (clipped): tail contains only the constant 0. 
PASS < [Tests AudioBufferSourceNode start()] All assertions passed. (total 18
assertions) 
PASS # AUDIT TASK RUNNER FINISHED: 1 tasks ran successfully. 
Harness: the test ran to completion.

[Raymond Toy, 2017-01-13 19:04:06]

Output for loop-comprehensive:

This is a testharness.js-based test.
PASS # AUDIT TASK RUNNER STARTED. 
PASS   Generate 19 test cases did not throw an exception. 
PASS   Case 0: loop whole buffer by default with loopStart == loopEnd == 0 is
identical to the array [0,1,2,3,4,5,6,7,0,1,2,3,4,5,6,7...]. 
PASS   Case 0: loop whole buffer by default with loopStart == loopEnd == 0: tail
contains only the constant 0. 
PASS   Case 1: loop whole buffer explicitly is identical to the array
[0,1,2,3,4,5,6,7,0,1,2,3,4,5,6,7...]. 
PASS   Case 1: loop whole buffer explicitly: tail contains only the constant 0. 
PASS   Case 2: loop from middle to end of buffer is identical to the array
[0,1,2,3,4,5,6,7,4,5,6,7,4,5,6,7...]. 
PASS   Case 2: loop from middle to end of buffer: tail contains only the
constant 0. 
PASS   Case 3: loop from start to middle of buffer is identical to the array
[0,1,2,3,0,1,2,3,0,1,2,3,0,1,2,3...]. 
PASS   Case 3: loop from start to middle of buffer: tail contains only the
constant 0. 
PASS   Case 4: loop from 4 -> 6 is identical to the array
[0,1,2,3,4,5,4,5,4,5,4,5,4,5,4,5...]. 
PASS   Case 4: loop from 4 -> 6: tail contains only the constant 0. 
PASS   Case 5: loop from 3 -> 7 is identical to the array
[0,1,2,3,4,5,6,3,4,5,6,3,4,5,6,3...]. 
PASS   Case 5: loop from 3 -> 7: tail contains only the constant 0. 
PASS   Case 6: loop from 4 -> 6 with playbackRate of 0.5 is identical to the
array [0,0.5,1,1.5,2,2.5,3,3.5,4,4.5,5,5.5,4,4.5,5,5.5...]. 
PASS   Case 6: loop from 4 -> 6 with playbackRate of 0.5: tail contains only the
constant 0. 
PASS   Case 7: loop from 4 -> 6 with playbackRate of 1.5 is identical to the
array [0,1.5,3,4.5,4,5.5,5,4.5,4,5.5,5,4.5,4,5.5,5,4.5...]. 
PASS   Case 7: loop from 4 -> 6 with playbackRate of 1.5: tail contains only the
constant 0. 
PASS   Case 8: loop from 2 -> 5 with offset 6 is identical to the array
[2,3,4,2,3,4,2,3,4,2,3,4,2,3,4,2...]. 
PASS   Case 8: loop from 2 -> 5 with offset 6: tail contains only the constant
0. 
PASS   Case 9: loop from 3 -> 6 with offset 1 is identical to the array
[1,2,3,4,5,3,4,5,3,4,5,3,4,5,3,4...]. 
PASS   Case 9: loop from 3 -> 6 with offset 1: tail contains only the constant
0. 
PASS   Case 10: loop from 3 -> 6 with offset 4 is identical to the array
[4,5,3,4,5,3,4,5,3,4,5,3,4,5,3,4...]. 
PASS   Case 10: loop from 3 -> 6 with offset 4: tail contains only the constant
0. 
PASS   Case 11: illegal playbackRate of 47 greater than loop length is identical
to the array [0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0...]. 
PASS   Case 11: illegal playbackRate of 47 greater than loop length: tail
contains only the constant 0. 
PASS   Case 12: illegal loop: loopStartFrame > loopEndFrame is identical to the
array [0,1,2,3,4,5,6,7,0,1,2,3,4,5,6,7...]. 
PASS   Case 12: illegal loop: loopStartFrame > loopEndFrame: tail contains only
the constant 0. 
PASS   Case 13: illegal loop: loopStartFrame == loopEndFrame is identical to the
array [0,1,2,3,4,5,6,7,0,1,2,3,4,5,6,7...]. 
PASS   Case 13: illegal loop: loopStartFrame == loopEndFrame: tail contains only
the constant 0. 
PASS   Case 14: illegal loop: loopStartFrame < 0 is identical to the array
[0,1,2,3,4,5,6,7,0,1,2,3,4,5,6,7...]. 
PASS   Case 14: illegal loop: loopStartFrame < 0: tail contains only the
constant 0. 
PASS   Case 15: illegal loop: loopEndFrame > bufferLength is identical to the
array [0,1,2,3,4,5,6,7,0,1,2,3,4,5,6,7...]. 
PASS   Case 15: illegal loop: loopEndFrame > bufferLength: tail contains only
the constant 0. 
PASS   Case 16: loop from 3 -> 6 with offset 1 for 20 frames is identical to the
array [1,2,3,4,5,3,4,5,3,4,5,3,4,5,3,4...]. 
PASS   Case 16: loop from 3 -> 6 with offset 1 for 20 frames: tail contains only
the constant 0. 
PASS   Case 17: loop from 3 -> 8 with offset 1 for 3 frames is identical to the
array [1,2,3,0,0,0,0,0,0,0,0,0,0,0,0,0...]. 
PASS   Case 17: loop from 3 -> 8 with offset 1 for 3 frames: tail contains only
the constant 0. 
PASS   Case 18: loop from 3 -> 8 with offset 7 for 3 frames is identical to the
array [7,3,4,0,0,0,0,0,0,0,0,0,0,0,0,0...]. 
PASS   Case 18: loop from 3 -> 8 with offset 7 for 3 frames: tail contains only
the constant 0. 
PASS < [AudioBufferSource looping test] All assertions passed. (total 39
assertions) 
PASS # AUDIT TASK RUNNER FINISHED: 1 tasks ran successfully. 
Harness: the test ran to completion.

[hongchan, 2017-01-18 18:12:51]

On 2017/01/13 19:04:06, Raymond Toy wrote:
> Output for loop-comprehensive:
> 
> This is a testharness.js-based test.
> PASS # AUDIT TASK RUNNER STARTED. 
> PASS   Generate 19 test cases did not throw an exception. 
> PASS   Case 0: loop whole buffer by default with loopStart == loopEnd == 0 is
> identical to the array [0,1,2,3,4,5,6,7,0,1,2,3,4,5,6,7...]. 
> PASS   Case 0: loop whole buffer by default with loopStart == loopEnd == 0:
tail
> contains only the constant 0. 
> PASS   Case 1: loop whole buffer explicitly is identical to the array
> [0,1,2,3,4,5,6,7,0,1,2,3,4,5,6,7...]. 
> PASS   Case 1: loop whole buffer explicitly: tail contains only the constant
0. 
> PASS   Case 2: loop from middle to end of buffer is identical to the array
> [0,1,2,3,4,5,6,7,4,5,6,7,4,5,6,7...]. 
> PASS   Case 2: loop from middle to end of buffer: tail contains only the
> constant 0. 
> PASS   Case 3: loop from start to middle of buffer is identical to the array
> [0,1,2,3,0,1,2,3,0,1,2,3,0,1,2,3...]. 
> PASS   Case 3: loop from start to middle of buffer: tail contains only the
> constant 0. 
> PASS   Case 4: loop from 4 -> 6 is identical to the array
> [0,1,2,3,4,5,4,5,4,5,4,5,4,5,4,5...]. 
> PASS   Case 4: loop from 4 -> 6: tail contains only the constant 0. 
> PASS   Case 5: loop from 3 -> 7 is identical to the array
> [0,1,2,3,4,5,6,3,4,5,6,3,4,5,6,3...]. 
> PASS   Case 5: loop from 3 -> 7: tail contains only the constant 0. 
> PASS   Case 6: loop from 4 -> 6 with playbackRate of 0.5 is identical to the
> array [0,0.5,1,1.5,2,2.5,3,3.5,4,4.5,5,5.5,4,4.5,5,5.5...]. 
> PASS   Case 6: loop from 4 -> 6 with playbackRate of 0.5: tail contains only
the
> constant 0. 
> PASS   Case 7: loop from 4 -> 6 with playbackRate of 1.5 is identical to the
> array [0,1.5,3,4.5,4,5.5,5,4.5,4,5.5,5,4.5,4,5.5,5,4.5...]. 
> PASS   Case 7: loop from 4 -> 6 with playbackRate of 1.5: tail contains only
the
> constant 0. 
> PASS   Case 8: loop from 2 -> 5 with offset 6 is identical to the array
> [2,3,4,2,3,4,2,3,4,2,3,4,2,3,4,2...]. 
> PASS   Case 8: loop from 2 -> 5 with offset 6: tail contains only the constant
> 0. 
> PASS   Case 9: loop from 3 -> 6 with offset 1 is identical to the array
> [1,2,3,4,5,3,4,5,3,4,5,3,4,5,3,4...]. 
> PASS   Case 9: loop from 3 -> 6 with offset 1: tail contains only the constant
> 0. 
> PASS   Case 10: loop from 3 -> 6 with offset 4 is identical to the array
> [4,5,3,4,5,3,4,5,3,4,5,3,4,5,3,4...]. 
> PASS   Case 10: loop from 3 -> 6 with offset 4: tail contains only the
constant
> 0. 
> PASS   Case 11: illegal playbackRate of 47 greater than loop length is
identical
> to the array [0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0...]. 
> PASS   Case 11: illegal playbackRate of 47 greater than loop length: tail
> contains only the constant 0. 
> PASS   Case 12: illegal loop: loopStartFrame > loopEndFrame is identical to
the
> array [0,1,2,3,4,5,6,7,0,1,2,3,4,5,6,7...]. 
> PASS   Case 12: illegal loop: loopStartFrame > loopEndFrame: tail contains
only
> the constant 0. 
> PASS   Case 13: illegal loop: loopStartFrame == loopEndFrame is identical to
the
> array [0,1,2,3,4,5,6,7,0,1,2,3,4,5,6,7...]. 
> PASS   Case 13: illegal loop: loopStartFrame == loopEndFrame: tail contains
only
> the constant 0. 
> PASS   Case 14: illegal loop: loopStartFrame < 0 is identical to the array
> [0,1,2,3,4,5,6,7,0,1,2,3,4,5,6,7...]. 
> PASS   Case 14: illegal loop: loopStartFrame < 0: tail contains only the
> constant 0. 
> PASS   Case 15: illegal loop: loopEndFrame > bufferLength is identical to the
> array [0,1,2,3,4,5,6,7,0,1,2,3,4,5,6,7...]. 
> PASS   Case 15: illegal loop: loopEndFrame > bufferLength: tail contains only
> the constant 0. 
> PASS   Case 16: loop from 3 -> 6 with offset 1 for 20 frames is identical to
the
> array [1,2,3,4,5,3,4,5,3,4,5,3,4,5,3,4...]. 
> PASS   Case 16: loop from 3 -> 6 with offset 1 for 20 frames: tail contains
only
> the constant 0. 
> PASS   Case 17: loop from 3 -> 8 with offset 1 for 3 frames is identical to
the
> array [1,2,3,0,0,0,0,0,0,0,0,0,0,0,0,0...]. 
> PASS   Case 17: loop from 3 -> 8 with offset 1 for 3 frames: tail contains
only
> the constant 0. 
> PASS   Case 18: loop from 3 -> 8 with offset 7 for 3 frames is identical to
the
> array [7,3,4,0,0,0,0,0,0,0,0,0,0,0,0,0...]. 
> PASS   Case 18: loop from 3 -> 8 with offset 7 for 3 frames: tail contains
only
> the constant 0. 
> PASS < [AudioBufferSource looping test] All assertions passed. (total 39
> assertions) 
> PASS # AUDIT TASK RUNNER FINISHED: 1 tasks ran successfully. 
> Harness: the test ran to completion.

[hongchan, 2017-01-18 18:13:03]

https://codereview.chromium.org/2599573003/diff/40001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/webaudio/AudioBufferSource/audiobuffersource-loop-comprehensive.html
(right):

https://codereview.chromium.org/2599573003/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/AudioBufferSource/audiobuffersource-loop-comprehensive.html:196:
throw("renderFrames is required for test " + testNumber + ": " +
test.description);
Just throw? I have to think about this - do we have any other instance of using
'throw' when a test fails?

[Raymond Toy, 2017-01-18 18:16:43]

On 2017/01/18 18:13:03, hongchan (OOO 1.17-1.19) wrote:
>
https://codereview.chromium.org/2599573003/diff/40001/third_party/WebKit/Layo...
> File
>
third_party/WebKit/LayoutTests/webaudio/AudioBufferSource/audiobuffersource-loop-comprehensive.html
> (right):
> 
>
https://codereview.chromium.org/2599573003/diff/40001/third_party/WebKit/Layo...
>
third_party/WebKit/LayoutTests/webaudio/AudioBufferSource/audiobuffersource-loop-comprehensive.html:196:
> throw("renderFrames is required for test " + testNumber + ": " +
> test.description);
> Just throw? I have to think about this - do we have any other instance of
using
> 'throw' when a test fails?

I doubt it. I think I did this because I forget several times to add
renderFrames to certain tests and the tests then do something weird.  This makes
it really clear that the test config itself is messed up, not the tests
themselves.

[hongchan, 2017-01-20 18:40:21]

https://codereview.chromium.org/2599573003/diff/40001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/webaudio/resources/audiobuffersource-testing.js
(right):

https://codereview.chromium.org/2599573003/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/resources/audiobuffersource-testing.js:2:
var audioBuffer = context.createBuffer(1, sampleFrameLength,
context.sampleRate);
var => let (all instances in here)

[Raymond Toy, 2017-01-20 22:17:27]

https://codereview.chromium.org/2599573003/diff/40001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/webaudio/resources/audiobuffersource-testing.js
(right):

https://codereview.chromium.org/2599573003/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/resources/audiobuffersource-testing.js:2:
var audioBuffer = context.createBuffer(1, sampleFrameLength,
context.sampleRate);
On 2017/01/20 18:40:21, hongchan wrote:
> var => let (all instances in here)

Done.

[hongchan, 2017-01-20 23:10:23]

lgtm

[Raymond Toy, 2017-01-20 23:23:59]

The CQ bit was checked by rtoy@chromium.org

[commit-bot: I haz the power, 2017-01-20 23:24:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-21 00:25:03]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1484954639828390,
"parent_rev": "acf567697de4b29d5c60c4d14b72ab1f51af95b3", "commit_rev":
"3ae4ce708f660411f8a26da7a4382c6842c75346"}

[commit-bot: I haz the power, 2017-01-21 00:25:34]

Description was changed from

==========
Convert AudioBufferSource start and loop-comprehensive tests to testharness

Manually convert test to use testharness

BUG=676394
TEST=audiobuffersource-start.html, audiobuffersource-loop-comprehensive.html
==========

to

==========
Convert AudioBufferSource start and loop-comprehensive tests to testharness

Manually convert test to use testharness

BUG=676394
TEST=audiobuffersource-start.html, audiobuffersource-loop-comprehensive.html

Review-Url: https://codereview.chromium.org/2599573003
Cr-Commit-Position: refs/heads/master@{#445224}
Committed:
https://chromium.googlesource.com/chromium/src/+/3ae4ce708f660411f8a26da7a438...
==========

[commit-bot: I haz the power, 2017-01-21 00:25:35]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/3ae4ce708f660411f8a26da7a438...