Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Unified Diff: third_party/WebKit/Source/core/dom/Fullscreen.cpp

Issue 2599573002: [SPInvalidation] Update paint properties when full screen status changes (Closed)
Patch Set: [SPInvalidation] Update paint properties when full screen status changes Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/dom/Fullscreen.cpp
diff --git a/third_party/WebKit/Source/core/dom/Fullscreen.cpp b/third_party/WebKit/Source/core/dom/Fullscreen.cpp
index 40cc448ea83432ef3af4c7b89bb3ee7d81c14073..1360deb41651440382f8310cb768a453f64035e3 100644
--- a/third_party/WebKit/Source/core/dom/Fullscreen.cpp
+++ b/third_party/WebKit/Source/core/dom/Fullscreen.cpp
@@ -34,6 +34,7 @@
#include "core/dom/ElementTraversal.h"
#include "core/dom/StyleEngine.h"
#include "core/events/Event.h"
+#include "core/frame/FrameView.h"
#include "core/frame/HostsUsingFeatures.h"
#include "core/frame/LocalFrame.h"
#include "core/frame/Settings.h"
@@ -894,6 +895,14 @@ void Fullscreen::fullscreenElementChanged(Element* fromElement,
// https://crbug.com/668758
frame->eventHandler().scheduleHoverStateUpdate();
frame->chromeClient().fullscreenElementChanged(fromElement, toElement);
+
+ if (RuntimeEnabledFeatures::slimmingPaintInvalidationEnabled() &&
+ !RuntimeEnabledFeatures::rootLayerScrollingEnabled()) {
+ // Fullscreen status affects scroll paint properties through
+ // FrameView::userInputScrollable().
+ if (FrameView* frameView = frame->view())
+ frame->view()->setNeedsPaintPropertyUpdate();
pdr. 2016/12/22 00:37:16 nit: use the local variable: if (FrameView* frameV
Xianzhu 2016/12/22 00:45:29 Done.
+ }
}
// TODO(foolip): This should not call updateStyleAndLayoutTree.
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/frame/FrameView.cpp » ('j') | third_party/WebKit/Source/core/frame/FrameView.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698