Extract helper function.

Extract helper function to calculate offsets for painting a DocumentMarker.
Also it is possible to pass DocumentMarker objects to painting functions by const ref instead of pointer.

No behavior changes.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/6275485d7a75bfaae1a66852e80113ffd468ee2f
Cr-Commit-Position: refs/heads/master@{#440662}

[Andrey Kraynov, 2016-12-21 17:14:38]

Description was changed from

==========
Extract helper function.

No behavior changes.

BUG=
==========

to

==========
Extract helper function.

No behavior changes.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[Andrey Kraynov, 2016-12-21 17:39:10]

Description was changed from

==========
Extract helper function.

No behavior changes.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Extract helper function to calculate offsets for painting a DocumentMarker.
Also it is possible to pass DocumentMarker objects to painting functions by
const ref instead of pointer.

No behavior changes.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[Andrey Kraynov, 2016-12-21 17:40:47]

iceman@yandex-team.ru changed reviewers:
+ chrishtr@chromium.org

[Andrey Kraynov, 2016-12-21 17:43:18]

Hi!

I tried to simplify some lines of code, could you take a look please?

https://codereview.chromium.org/2599483002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/line/InlineTextBox.h (left):

https://codereview.chromium.org/2599483002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/line/InlineTextBox.h:138: // These
functions both paint markers and update the DocumentMarker's
This comment seems outdated at the moment.
paintDocumentMarker* functions have nothing to do with markers rect, and can
take just a |const &| instead of a pointer.

https://codereview.chromium.org/2599483002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/paint/InlineTextBoxPainter.cpp (left):

https://codereview.chromium.org/2599483002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/paint/InlineTextBoxPainter.cpp:1218:
std::max(marker->startOffset() - m_inlineTextBox.start(), (unsigned)0);
This is obviously pointless call to std::max() function, because type of the
|marker->startOffset() - m_inlineTextBox.start()| expression is |unsigned| and
it will always greater that 0.
Compiler can even give a warning for the following code:
|std::max(someUnsignedValue, 0U);|
taking the max of a value and unsigned zero is always equal to the other value
[-Werror,-Wmax-unsigned-zero]

Also, TextPainter::paint() function takes offsets as |unsigned|.

[Andrey Kraynov, 2016-12-23 20:30:24]

iceman@yandex-team.ru changed reviewers:
+ yutak@chromium.org

[Andrey Kraynov, 2016-12-23 20:31:09]

yutak@, maybe you will have time to look at this?
Thanks in advance!

[chrishtr, 2016-12-23 20:53:42]

Description was changed from

==========
Extract helper function to calculate offsets for painting a DocumentMarker.
Also it is possible to pass DocumentMarker objects to painting functions by
const ref instead of pointer.

No behavior changes.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Extract helper function to calculate offsets for painting a DocumentMarker.
Also it is possible to pass DocumentMarker objects to painting functions by
const ref instead of pointer.

No behavior changes.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[chrishtr, 2016-12-23 20:57:19]

https://codereview.chromium.org/2599483002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/paint/InlineTextBoxPainter.cpp (right):

https://codereview.chromium.org/2599483002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/paint/InlineTextBoxPainter.cpp:30: const unsigned
startOffset = marker.startOffset() > textBox.start()
Why not just use std::max like the code used to?

[Andrey Kraynov, 2016-12-23 22:27:47]

https://codereview.chromium.org/2599483002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/paint/InlineTextBoxPainter.cpp (right):

https://codereview.chromium.org/2599483002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/paint/InlineTextBoxPainter.cpp:30: const unsigned
startOffset = marker.startOffset() > textBox.start()
On 2016/12/23 20:57:19, chrishtr wrote:
> Why not just use std::max like the code used to?

But then it will look like |std::max(someUnsignedIntValue, 0U)|.
Which is strange, because |someUnsignedIntValue| will be always greater than 0.

[Andrey Kraynov, 2016-12-23 22:31:00]

https://codereview.chromium.org/2599483002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/paint/InlineTextBoxPainter.cpp (right):

https://codereview.chromium.org/2599483002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/paint/InlineTextBoxPainter.cpp:30: const unsigned
startOffset = marker.startOffset() > textBox.start()
On 2016/12/23 22:27:47, Andrey Kraynov wrote:
> Which is strange, because |someUnsignedIntValue| will be always greater than
0.
Greater then or equal to 0, of course.

[chrishtr, 2016-12-23 23:38:05]

The CQ bit was checked by chrishtr@chromium.org

[chrishtr, 2016-12-23 23:38:05]

lgtm

[commit-bot: I haz the power, 2016-12-23 23:38:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-24 01:02:23]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1482536285185160, "parent_rev":
"7b6beec78ec1bcadc03c116228bcb6a6b4875aed", "commit_rev":
"975a341c44f1d5d6e5411b2724b7a987827549c6"}

[commit-bot: I haz the power, 2016-12-24 01:02:50]

Description was changed from

==========
Extract helper function to calculate offsets for painting a DocumentMarker.
Also it is possible to pass DocumentMarker objects to painting functions by
const ref instead of pointer.

No behavior changes.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Extract helper function to calculate offsets for painting a DocumentMarker.
Also it is possible to pass DocumentMarker objects to painting functions by
const ref instead of pointer.

No behavior changes.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2599483002
==========

[commit-bot: I haz the power, 2016-12-24 01:02:50]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-12-24 01:07:33]

Description was changed from

==========
Extract helper function to calculate offsets for painting a DocumentMarker.
Also it is possible to pass DocumentMarker objects to painting functions by
const ref instead of pointer.

No behavior changes.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2599483002
==========

to

==========
Extract helper function to calculate offsets for painting a DocumentMarker.
Also it is possible to pass DocumentMarker objects to painting functions by
const ref instead of pointer.

No behavior changes.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/6275485d7a75bfaae1a66852e80113ffd468ee2f
Cr-Commit-Position: refs/heads/master@{#440662}
==========

[commit-bot: I haz the power, 2016-12-24 01:07:34]

Patchset 1 (id:??) landed as
https://crrev.com/6275485d7a75bfaae1a66852e80113ffd468ee2f
Cr-Commit-Position: refs/heads/master@{#440662}